Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: markdownlint dev dependencies #14883

Merged
merged 1 commit into from Aug 7, 2021
Merged

Conversation

bmish
Copy link
Sponsor Member

@bmish bmish commented Aug 5, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[] Add something to the core
[X] Other, please explain:

What changes did you make? (Give an overview)

Updates markdownlint dev dependencies.

There's a new markdownlint rule that flags some violations in CHANGELOG.md:

CHANGELOG.md: 2745: MD037/no-space-in-emphasis Spaces inside emphasis markers [Context: "* exported *"]
CHANGELOG.md: 6361: MD037/no-space-in-emphasis Spaces inside emphasis markers [Context: "*global *"]
CHANGELOG.md: 6370: MD037/no-space-in-emphasis Spaces inside emphasis markers [Context: "*global *"]

The rule is MD037.

However, we likely do not want to lint CHANGELOG.md, since this file is autogenerated.

So I added a .markdownlintignore file which is respected by markdownlint-cli ([doc])(https://github.com/igorshubovych/markdownlint-cli#ignoring-files) when running on CLI and IDE extensions for markdownlint.

However, we have to manually filter out files in .markdownlintignore when using the NodeJS API for markdownlint itself (DavidAnson/markdownlint#159 (comment)).

Is there anything you'd like reviewers to focus on?

No.

@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Aug 5, 2021
@bmish bmish mentioned this pull request Aug 5, 2021
1 task
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snitin315 snitin315 added accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing and removed triage An ESLint team member will look at this issue soon labels Aug 6, 2021
@bmish bmish changed the title Chore: Update markdownlint dev dependencies Upgrade: markdownlint dev dependencies Aug 6, 2021
@bmish bmish changed the title Upgrade: markdownlint dev dependencies Upgrade: markdownlint dev dependencies Aug 6, 2021
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bmish bmish merged commit e53d8cf into eslint:master Aug 7, 2021
@bmish bmish deleted the markdownlint-0.23 branch August 7, 2021 18:35
bmish added a commit to bmish/eslint that referenced this pull request Aug 11, 2021
* master:
  Chore: Add rel/abs path tests in `no-restricted-{imports/modules}` rules (eslint#14910)
  Upgrade: Debug 4.0.1 > 4.3.2 (eslint#14892)
  Chore: add assertions on reporting location in `semi` (eslint#14899)
  Fix: no-useless-computed-key edge cases with class fields (refs eslint#14857) (eslint#14903)
  Upgrade: `js-yaml` to v4 (eslint#14890)
  Fix: prefer-destructuring PrivateIdentifier false positive (refs eslint#14857) (eslint#14897)
  Fix: dot-notation false positive with private identifier (refs eslint#14857) (eslint#14898)
  Sponsors: Sync README with website
  Sponsors: Sync README with website
  Docs: improve rule details for `no-console` (fixes eslint#14793) (eslint#14901)
  Update: check class fields in no-extra-parens (refs eslint#14857) (eslint#14906)
  Docs: add class fields in no-multi-assign documentation (refs eslint#14857) (eslint#14907)
  Docs: add class fields in func-names documentation (refs eslint#14857) (eslint#14908)
  Upgrade: `eslint-visitor-keys` to v3 (eslint#14902)
  Upgrade: `markdownlint` dev dependencies (eslint#14883)
  Upgrade: @humanwhocodes/config-array to 0.6 (eslint#14891)
  Chore: Specify Node 14.x for Verify Files CI job (eslint#14896)
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Feb 4, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants