-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
chore: Mark deprecated formatting rules as available until v11.0.0 #20144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-eslint canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would like another review before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
message: "Formatting rules are being moved out of ESLint core.", | ||
url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/", | ||
deprecatedSince: "4.0.0", | ||
availableUntil: "11.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
url: "https://eslint.org/blog/2017/06/eslint-v4.0.0-released/", | ||
deprecatedSince: "4.0.0", | ||
availableUntil: null, | ||
availableUntil: "11.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
url: "https://eslint.org/blog/2017/06/eslint-v4.0.0-released/", | ||
deprecatedSince: "4.0.0", | ||
availableUntil: null, | ||
availableUntil: "11.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
url: "https://eslint.org/blog/2017/06/eslint-v4.0.0-released/", | ||
deprecatedSince: "4.0.0", | ||
availableUntil: null, | ||
availableUntil: "11.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Refs #20097
Marks deprecated formatting rules as available until ESLint v11.0.0, i.e. planned for removal in ESLint v11.0.0.
This is a total of 74 rules:
line-comment-position
andmultiline-comment-style
.indent-legacy
,lines-around-directive
,newline-after-var
,newline-before-return
, andno-spaced-func
.What changes did you make? (Give an overview)
Updated/added
availableUntil: "11.0.0"
property ofmeta.deprecated
in 74 rules and 1 test.Is there anything you'd like reviewers to focus on?
Did I miss some rules?