Skip to content

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Refs #20097

Marks deprecated formatting rules as available until ESLint v11.0.0, i.e. planned for removal in ESLint v11.0.0.

This is a total of 74 rules:

  • 67 rules deprecated in v8.53.0. The list is here: https://eslint.org/blog/2023/10/deprecating-formatting-rules/.
  • 2 rules deprecated in v9.3.0: line-comment-position and multiline-comment-style.
  • 5 rules previously deprecated in favor of some of the above one: indent-legacy, lines-around-directive, newline-after-var, newline-before-return, and no-spaced-func.

What changes did you make? (Give an overview)

Updated/added availableUntil: "11.0.0" property of meta.deprecated in 74 rules and 1 test.

Is there anything you'd like reviewers to focus on?

Did I miss some rules?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Sep 20, 2025
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Sep 20, 2025
Copy link

netlify bot commented Sep 20, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 0f5010f
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/68cf163ea0184a0008f51156

@github-actions github-actions bot added the rule Relates to ESLint's core rules label Sep 20, 2025
@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Sep 20, 2025
@mdjermanovic mdjermanovic marked this pull request as ready for review September 20, 2025 21:19
@mdjermanovic mdjermanovic requested a review from a team as a code owner September 20, 2025 21:19
@aladdin-add aladdin-add moved this from Needs Triage to Implementing in Triage Sep 20, 2025
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would like another review before merging.

@aladdin-add aladdin-add moved this from Implementing to Second Review Needed in Triage Sep 21, 2025
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

message: "Formatting rules are being moved out of ESLint core.",
url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
deprecatedSince: "4.0.0",
availableUntil: "11.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

url: "https://eslint.org/blog/2017/06/eslint-v4.0.0-released/",
deprecatedSince: "4.0.0",
availableUntil: null,
availableUntil: "11.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

url: "https://eslint.org/blog/2017/06/eslint-v4.0.0-released/",
deprecatedSince: "4.0.0",
availableUntil: null,
availableUntil: "11.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

url: "https://eslint.org/blog/2017/06/eslint-v4.0.0-released/",
deprecatedSince: "4.0.0",
availableUntil: null,
availableUntil: "11.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fasttime fasttime merged commit 448b57b into main Sep 21, 2025
29 of 30 checks passed
@fasttime fasttime deleted the deprecate-formatting-rules-v11 branch September 21, 2025 17:35
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Sep 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing rule Relates to ESLint's core rules
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

3 participants