Fix: key-spacing shouldn't report object pattern properties #12047
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix
Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using?
default
Please show your full configuration:
Configuration
What did you do? Please include the actual source code causing the issue.
What did you expect to happen?
No warnings. By the documentation for this rule it targets object literals, these are object patterns.
Also, there are no test cases with patterns.
What actually happened? Please include the actual, raw output from ESLint.
1 warning, for
beforeColon
.No warnings for
align
.What changes did you make? (Give an overview)
Skip the check if the
Property
is not a property of anObjectExpression
.Is there anything you'd like reviewers to focus on?
I guess this should be treated as a bug rather than as an undocumented behavior because it doesn't work well - some options report warnings, some not.