Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[X] Other, please explain:
Upgrade
esquery
to1.2.0
What changes did you make? (Give an overview)
Upgraded
esquery
to1.2.0
and fixed some problems.This version has been released today and is causing ESLint builds to fail, for two reasons:
esquery.parse
do not haveoffset
property anymore, I think this was a change in pegjs.Some tests were (correctly) failing because of this. It's fixed by using
err.location.start.offset
.esquery
now distributes ESM modules, too.Webpack by default looks for
"module"
(ESM) first. Unfortunately, that module is usingexport default
, which turnsrequire("esquery")
into something like:instead of expected:
This produces an invalid
build/eslint.js
bundle.Might be relevant issue: webpack/webpack#4742
It's fixed by configuring webpack to always look for
"main"
first.Is there anything you'd like reviewers to focus on?
The size of
build/eslint.js
increased by only ~1KB.