Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: add node v17

Merged
merged 2 commits into from Oct 21, 2021
Merged

Build: add node v17 #15193

merged 2 commits into from Oct 21, 2021

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Oct 20, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ x] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

no.

@eslint-github-bot eslint-github-bot bot added the triage label Oct 20, 2021
@aladdin-add aladdin-add added accepted build and removed triage labels Oct 20, 2021
@aladdin-add
Copy link
Member Author

aladdin-add commented Oct 20, 2021

blocked by gajus/eslint-plugin-jsdoc#791


update: fixed in 72e4b53

bmish
bmish approved these changes Oct 20, 2021
nzakas
nzakas approved these changes Oct 20, 2021
@@ -43,10 +43,10 @@ jobs:
- name: Install Packages
run: npm install
# TODO(btmills): Remove Node 16 --force branching after releasing v8.0.0 final.
if: ${{ !startswith(matrix.node, '16') }}
if: ${{ !startswith(matrix.node, '16') && !startswith(matrix.node, '17') }}
Copy link
Member

@nzakas nzakas Oct 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment above this line indicates we should be able to remove all checks for Node 16? So we probably don’t need to add Node 17, just remove the Node 16 stuff?

Copy link
Member Author

@aladdin-add aladdin-add Oct 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As seen in here, eslint-plugin-jsdoc has not not fully supported eslint v8 yet. We will have to wait it been fixed: gajus/eslint-plugin-jsdoc#791

Copy link
Member

@mdjermanovic mdjermanovic left a comment

LGTM, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted archived due to age build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants