Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add latest/ to meta.docs.url in all core rules #17136

Merged
merged 1 commit into from
Apr 29, 2023

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Updates meta.docs.url from https://eslint.org/docs/rules/rule-name to https://eslint.org/docs/latest/rules/rule-name in all core rules to avoid redirects.

What changes did you make? (Give an overview)

Updated pattern in our configuration for the eslint-plugin/require-meta-docs-url rule and ran npm run lint:fix.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Apr 29, 2023
@mdjermanovic mdjermanovic requested a review from a team as a code owner April 29, 2023 17:41
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Apr 29, 2023
@netlify
Copy link

netlify bot commented Apr 29, 2023

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 2c01e79
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/644d56c4ea886c0008c69513

Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aladdin-add aladdin-add merged commit 9094d79 into main Apr 29, 2023
@aladdin-add aladdin-add deleted the meta-url-latest branch April 29, 2023 18:02
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Oct 27, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants