Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add no-useless-assignment rule #17625

Merged
merged 40 commits into from
Jan 9, 2024
Merged

feat: add no-useless-assignment rule #17625

merged 40 commits into from
Jan 9, 2024

Commits on Oct 7, 2023

  1. feat: add no-useless-assignment rule

    @ota-meshi
    ota-meshi committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    fa14942 View commit details
    Browse the repository at this point in the history

  2. fix: add test cases and fix

    @ota-meshi
    ota-meshi committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    020ee4f View commit details
    Browse the repository at this point in the history

  3. chore: remove wrong comment

    @ota-meshi
    ota-meshi committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    35327ba View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. test: add test and update

    @ota-meshi
    ota-meshi committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    ca5c5c2 View commit details
    Browse the repository at this point in the history

  2. feat: report if it is not used between assignments

    @ota-meshi
    ota-meshi committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    3d63f0f View commit details
    Browse the repository at this point in the history

  3. fix: add test case and fix

    @ota-meshi
    ota-meshi committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    7e2692e View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
    @ota-meshi @nzakas
    ota-meshi and nzakas authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    6bb7f65 View commit details
    Browse the repository at this point in the history

  2. docs: update

    @ota-meshi
    ota-meshi committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    fb050c3 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. fix: false negatives for same segments & refactor

    @ota-meshi
    ota-meshi committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    eb5e982 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into no-useless-assignment

    @ota-meshi
    ota-meshi committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    d9e3769 View commit details
    Browse the repository at this point in the history

  3. fix: rule-types.json

    @ota-meshi
    ota-meshi committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    c8ab128 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. fix: add update assignment test case & fix

    @ota-meshi
    ota-meshi committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    d3c1223 View commit details
    Browse the repository at this point in the history

  2. fix: add test for global vars & fix

    @ota-meshi
    ota-meshi committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    96dd2ac View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2023

  1. Update docs/src/rules/no-useless-assignment.md 

    Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
    @ota-meshi @nzakas
    ota-meshi and nzakas authored Nov 5, 2023
    Configuration menu
    Copy the full SHA
    1a2efc0 View commit details
    Browse the repository at this point in the history

  2. docs: update description

    @ota-meshi
    ota-meshi committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    e21b292 View commit details
    Browse the repository at this point in the history

  3. docs: add further_reading

    @ota-meshi
    ota-meshi committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    06f9698 View commit details
    Browse the repository at this point in the history

  4. chore: improve jsdoc and rename function

    @ota-meshi
    ota-meshi committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    a68ab8d View commit details
    Browse the repository at this point in the history

  5. docs: update doc

    @ota-meshi
    ota-meshi committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    09a2a22 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/main' into no-useless-assignment

    @ota-meshi
    ota-meshi committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    a102c12 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. fix: false positives for try catch

    @ota-meshi
    ota-meshi committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    5c56a3e View commit details
    Browse the repository at this point in the history

  2. test: fix tests/conf/eslint-all.js

    @ota-meshi
    ota-meshi committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    6ca9835 View commit details
    Browse the repository at this point in the history

  3. feat: add no-useless-assignment to eslint-config-eslint

    @ota-meshi
    ota-meshi committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    153e5dc View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. docs: fix document

    @ota-meshi
    ota-meshi committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    91c0a23 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. Update docs/src/rules/no-useless-assignment.md 

    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @ota-meshi @mdjermanovic
    ota-meshi and mdjermanovic authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    d4683ce View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. fix: false negatives

    @ota-meshi
    ota-meshi committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    7bb5240 View commit details
    Browse the repository at this point in the history

  2. docs: add example code

    @ota-meshi
    ota-meshi committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    360674d View commit details
    Browse the repository at this point in the history

  3. test: move test case

    @ota-meshi
    ota-meshi committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    7e696f8 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2023

  1. fix: false positives for assignment pattern

    @ota-meshi
    ota-meshi committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    a2b9339 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Merge remote-tracking branch 'upstream/main' into no-useless-assignment

    @ota-meshi
    ota-meshi committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    d0e6ef9 View commit details
    Browse the repository at this point in the history

  2. test: use flat-rule-tester

    @ota-meshi
    ota-meshi committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    6fce049 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2023

  1. Update lib/rules/no-useless-assignment.js 

    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @ota-meshi @mdjermanovic
    ota-meshi and mdjermanovic authored Dec 17, 2023
    Configuration menu
    Copy the full SHA
    a83dfde View commit details
    Browse the repository at this point in the history

  2. fix: false positives for finally block

    @ota-meshi
    ota-meshi committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    8a10c7f View commit details
    Browse the repository at this point in the history

  3. fix: false positives for markVariableAsUsed()

    @ota-meshi
    ota-meshi committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    a6e5843 View commit details
    Browse the repository at this point in the history

  4. chore: rename function

    @ota-meshi
    ota-meshi committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    cf5dd30 View commit details
    Browse the repository at this point in the history

  5. fix: false positives for unreachable segments

    @ota-meshi
    ota-meshi committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    b3d0d92 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2023

  1. Update lib/rules/no-useless-assignment.js 

    Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
    @ota-meshi @nzakas
    ota-meshi and nzakas authored Dec 27, 2023
    Configuration menu
    Copy the full SHA
    8ecc87c View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into no-useless-assignment

    @ota-meshi
    ota-meshi committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    011330a View commit details
    Browse the repository at this point in the history

  3. test: revert tests/conf/eslint-all.js

    @ota-meshi
    ota-meshi committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    adf0fb4 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Merge remote-tracking branch 'upstream/main' into no-useless-assignment

    @ota-meshi
    ota-meshi committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    fe8053b View commit details
    Browse the repository at this point in the history

  2. test: use rule-tester

    @ota-meshi
    ota-meshi committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    f616420 View commit details
    Browse the repository at this point in the history