fix: don't use path.extname with undefined value #5683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, @thealphanerd! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
|
By analyzing the blame information on this pull request, we identified @ilyavolodin, @nzakas and @gyandeeps to be potential reviewers |
|
LGTM. Thanks for the change. Could you change commit message to "Fix: don't use path.extname with undefined value (fixes #5678)" please? We use fixes to generate changelog with links at release time. |
In the current versions of node path.* can be called on any arbitrary value and will return an empty string on invalid input. As of node v6 path will assert that values passed to it are strings, and as such will throw on `undefined` This commit moved the logic of using `path.extname` inside of the processText function in `lib/cli-engine.js`. so that it will not call `path.extname` if a filename is not passed. This change should not affect any other parts of the system, and the test suite is 100% working on node v4, v5, and master. fixes eslint#5678
MylesBorins
force-pushed
the
validate-before-using-path
branch
from
ce07711
to
c41fab9
Compare
|
updated |
|
Awesome! Thanks for doing this. I'll merge this after next patch release. |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current versions of node path.* can be called on any arbitrary
value and will return an empty string on invalid input.
As of node v6 path will assert that values passed to it are strings,
and as such will throw on
undefinedThis commit moved the logic of using
path.extnameinside of theprocessText function in
lib/cli-engine.js. so that it will not callpath.extnameif a filename is not passed.This change should not affect any other parts of the system, and the
test suite is 100% working on node v4, v5, and master.
fixes #5678