Chore: Test fixes for CascadingConfigArrayFactory (#17)

* Chore: Fix ConfigArrayFactory tests

* Make more tests pass

* Chore: Fix CascadingConfigArrayFactory tests

* Fix more tests

* sync with main branch

* More test fixes

* cleanup tests

* Enable testing all files

* Hopefully last test fixes

* Single out failing CI test

* Add debugging

* Add debugging

* Revert

* Add missing fixture files

* Fix npm test command

* Update tests/lib/cascading-config-array-factory.js

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

* Remove teardowns completely

* Update package.json

Co-authored-by: Brandon Mills <btmills@users.noreply.github.com>

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Co-authored-by: Brandon Mills <btmills@users.noreply.github.com>

.gitignore

@@ -38,7 +38,7 @@ bower_components
 build/Release
 
 # Dependency directories
-node_modules/
+/node_modules/
 jspm_packages/
 
 # TypeScript v1 declaration files

lib/config-array/ignore-pattern.js

@@ -36,7 +36,7 @@
 const assert = require("assert");
 const path = require("path");
 const ignore = require("ignore");
-const debug = require("debug")("eslint:ignore-pattern");
+const debug = require("debug")("eslintrc:ignore-pattern");
 
 /** @typedef {ReturnType<import("ignore").default>} Ignore */
 

package.json

@@ -13,7 +13,7 @@
   },
   "scripts": {
     "lint": "eslint .",
-    "test": "mocha -R progress -c tests/lib/shared tests/lib/config-array tests/lib/shared tests/lib/config-array-factory.js",
+    "test": "mocha -R progress -c 'tests/lib/**/*.js'",
     "generate-release": "eslint-generate-release",
     "generate-alpharelease": "eslint-generate-prerelease alpha",
     "generate-betarelease": "eslint-generate-prerelease beta",

tests/fixtures/.eslintrc.yml

@@ -0,0 +1,2 @@
+# Prevent tests from going above this directory
+root: true

tests/fixtures/config-extends/.eslintrc

@@ -0,0 +1,12 @@
+{
+    "extends": "./subdir/.eslintrc",
+
+    "rules": {
+        "quotes": [2, "double"],
+        "valid-jsdoc": 0
+    },
+
+    "env": {
+        "browser": false
+    }
+}

tests/fixtures/config-extends/array/.eslintrc

@@ -0,0 +1,14 @@
+{
+    "extends": [
+        ".eslintrc1",
+        ".eslintrc2"
+    ],
+
+    "rules": {
+        "no-empty": 1
+    },
+
+    "env": {
+        "browser": false
+    }
+}

tests/fixtures/config-extends/array/.eslintrc1

@@ -0,0 +1,12 @@
+{
+    "rules": {
+        "comma-dangle": 1,
+        "no-console": 2,
+        "no-empty": 2
+    },
+
+    "env": {
+        "browser": true,
+        "node": true
+    }
+}

tests/fixtures/config-extends/array/.eslintrc2

@@ -0,0 +1,9 @@
+{
+    "rules": {
+        "comma-dangle": 2
+    },
+
+    "env": {
+        "es6": true
+    }
+}

tests/fixtures/config-extends/deep.json

@@ -0,0 +1,11 @@
+{
+    "rules": {
+        "yoda": 2
+    },
+
+    "env": {
+        "browser": true
+    },
+
+    "extends": "./subdir/subsubdir/deeper.json"
+}

tests/fixtures/config-extends/error.json

@@ -0,0 +1,3 @@
+{
+    "extends": "./non-existant.json"
+}

tests/fixtures/config-extends/js/.eslintrc

@@ -0,0 +1,12 @@
+{
+    "extends": "./foo.js",
+
+    "rules": {
+        "quotes": [2, "double"],
+        "valid-jsdoc": 0
+    },
+
+    "env": {
+        "browser": false
+    }
+}

tests/fixtures/config-extends/package.json

@@ -0,0 +1,7 @@
+{
+    "name": "test",
+    "version": "0.1.1",
+    "eslintConfig": {
+        "extends": "./subdir/.eslintrc"
+    }
+}

tests/fixtures/config-extends/package/.eslintrc

@@ -0,0 +1,12 @@
+{
+    "extends": "eslint-config-foo",
+
+    "rules": {
+        "quotes": [2, "double"],
+        "valid-jsdoc": 0
+    },
+
+    "env": {
+        "browser": false
+    }
+}

tests/fixtures/config-extends/package2/.eslintrc

@@ -0,0 +1,12 @@
+{
+    "extends": "foo",
+
+    "rules": {
+        "quotes": [2, "double"],
+        "valid-jsdoc": 0
+    },
+
+    "env": {
+        "browser": false
+    }
+}

tests/fixtures/config-extends/package2/subdir/foo.js

@@ -0,0 +1 @@
+var a = 1;

tests/fixtures/config-extends/package3/.eslintrc

@@ -0,0 +1,12 @@
+{
+    "extends": "foo/bar",
+
+    "rules": {
+        "quotes": [2, "double"],
+        "valid-jsdoc": 0
+    },
+
+    "env": {
+        "browser": false
+    }
+}

tests/fixtures/config-extends/package4/.eslintrc

@@ -0,0 +1,12 @@
+{
+    "extends": "bar-eslint-config-foo",
+
+    "rules": {
+        "quotes": [2, "double"],
+        "valid-jsdoc": 0
+    },
+
+    "env": {
+        "browser": false
+    }
+}

tests/fixtures/config-extends/resolving-relatively/.eslintrc.json

@@ -0,0 +1,3 @@
+{
+    "extends": "a"
+}

tests/fixtures/config-extends/scoped-package/.eslintrc

@@ -0,0 +1,12 @@
+{
+    "extends": "@scope/eslint-config-foo",
+
+    "rules": {
+        "quotes": [2, "double"],
+        "valid-jsdoc": 0
+    },
+
+    "env": {
+        "browser": false
+    }
+}

tests/fixtures/config-extends/scoped-package2/.eslintrc

@@ -0,0 +1,12 @@
+{
+    "extends": "@scope/foo",
+
+    "rules": {
+        "quotes": [2, "double"],
+        "valid-jsdoc": 0
+    },
+
+    "env": {
+        "browser": false
+    }
+}

tests/fixtures/config-extends/scoped-package3/.eslintrc

@@ -0,0 +1,12 @@
+{
+    "extends": "@scope/foo/bar",
+
+    "rules": {
+        "quotes": [2, "double"],
+        "valid-jsdoc": 0
+    },
+
+    "env": {
+        "browser": false
+    }
+}

tests/fixtures/config-extends/scoped-package3/foo.js

@@ -0,0 +1 @@
+var a = 1;

tests/fixtures/config-extends/scoped-package4/.eslintrc

@@ -0,0 +1,12 @@
+{
+    "extends": "@scope/eslint-config",
+
+    "rules": {
+        "quotes": [2, "double"],
+        "valid-jsdoc": 0
+    },
+
+    "env": {
+        "browser": false
+    }
+}

tests/fixtures/config-extends/scoped-package5/.eslintrc

@@ -0,0 +1,12 @@
+{
+    "extends": "@scope/",
+
+    "rules": {
+        "quotes": [2, "double"],
+        "valid-jsdoc": 0
+    },
+
+    "env": {
+        "browser": false
+    }
+}

tests/fixtures/config-extends/scoped-package6/.eslintrc

@@ -0,0 +1,12 @@
+{
+    "extends": "@scope",
+
+    "rules": {
+        "quotes": [2, "double"],
+        "valid-jsdoc": 0
+    },
+
+    "env": {
+        "browser": false
+    }
+}

tests/fixtures/config-extends/scoped-package7/.eslintrc

@@ -0,0 +1,12 @@
+{
+    "extends": "@scope/eslint-configfoo",
+
+    "rules": {
+        "quotes": [2, "double"],
+        "valid-jsdoc": 0
+    },
+
+    "env": {
+        "browser": false
+    }
+}

tests/fixtures/config-extends/scoped-package8/.eslintrc

@@ -0,0 +1,12 @@
+{
+    "extends": "@scope/bar-eslint-config-foo",
+
+    "rules": {
+        "quotes": [2, "double"],
+        "valid-jsdoc": 0
+    },
+
+    "env": {
+        "browser": false
+    }
+}

tests/fixtures/config-extends/scoped-package9/.eslintrc

@@ -0,0 +1,12 @@
+{
+    "extends": "@scope/eslint-config/foo",
+
+    "rules": {
+        "quotes": [2, "double"],
+        "valid-jsdoc": 0
+    },
+
+    "env": {
+        "browser": false
+    }
+}

tests/fixtures/config-extends/subdir/.eslintrc

@@ -0,0 +1,10 @@
+{
+    "rules": {
+        "quotes": [1, "single"],
+        "yoda": 2
+    },
+
+    "env": {
+        "browser": true
+    }
+}

tests/fixtures/config-extends/subdir/subsubdir/deeper.json

@@ -0,0 +1,11 @@
+{
+    "rules": {
+        "semi": 2
+    },
+
+    "env": {
+        "browser": false
+    },
+
+    "extends": "./subsubsubdir/deepest.json"
+}

tests/fixtures/config-extends/subdir/subsubdir/subsubsubdir/deepest.json

@@ -0,0 +1,10 @@
+{
+    "rules": {
+        "semi": 1,
+        "valid-jsdoc": 0
+    },
+
+    "env": {
+        "browser": true
+    }
+}

tests/fixtures/config-file/bom/.eslintrc.json

@@ -0,0 +1,5 @@
+{
+    "rules": {
+        "semi": "error"
+    }
+}

tests/fixtures/config-file/bom/.eslintrc.yaml

@@ -0,0 +1,2 @@
+rules:
+    semi: error

tests/fixtures/config-file/bom/package.json

@@ -0,0 +1,10 @@
+{
+    "private": true,
+    "name": "eslint-test",
+    "version": "0.0.0",
+    "eslintConfig": {
+        "rules": {
+            "semi": "error"
+        }
+    }
+}

tests/fixtures/config-file/broken-package-json/package.json

@@ -0,0 +1,6 @@
+{
+    "eslintConfig": {
+        "env": {
+            "es6": true
+        }
+    }

tests/fixtures/config-file/cjs/.eslintrc.cjs

@@ -0,0 +1,5 @@
+module.exports = {
+    rules: {
+        semi: [2, "always"]
+    }
+};

tests/fixtures/config-file/ecma-features/.eslintrc.yml

@@ -0,0 +1 @@
+ecmaFeatures: {}

tests/fixtures/config-file/extends-chain-2/.eslintrc.json

@@ -0,0 +1,3 @@
+{
+    "extends": "a"
+}