Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect release number #6

Closed
nzakas opened this issue Sep 1, 2020 · 4 comments · Fixed by eslint/eslint-release#45
Closed

Incorrect release number #6

nzakas opened this issue Sep 1, 2020 · 4 comments · Fixed by eslint/eslint-release#45
Assignees
@nzakas
Labels
accepted bug Something isn't working

Comments

@nzakas
Copy link
Member

nzakas commented Sep 1, 2020

Instead of releasing v0.1.1, the release process output v0.0.1.

I'm looking into this.
@nzakas nzakas added bug Something isn't working accepted labels Sep 1, 2020
@nzakas nzakas self-assigned this Sep 1, 2020
@nzakas
Copy link
Member Author

nzakas commented Sep 1, 2020

My best guess as to why this happened: it appears the release bot is not pushing the released artifacts back into GitHub. Two theories:

  1. The recent changes to eslint-release aren't working.
  2. The release bot doesn't have permission to push.

My best guess is that it's the first cause as there are no errors in the release log.

@nzakas
Copy link
Member Author

nzakas commented Sep 1, 2020

I've set git config --global push.default current on the release server. Let's see if that works.

nzakas added a commit that referenced this issue Sep 1, 2020
@nzakas
Fix: Release version number (refs #6)
01365fa
nzakas added a commit that referenced this issue Sep 1, 2020
@nzakas
Fix: Release version number (refs #6) (#8)
76796f6
This was referenced Sep 1, 2020
Merged
Closed
@nzakas nzakas reopened this Sep 1, 2020
@nzakas
Copy link
Member Author

nzakas commented Sep 1, 2020

Accidentally closed. This issue is not yet resolved.

nzakas added a commit that referenced this issue Sep 1, 2020
@nzakas
Fix: version number and eslint-release version (refs #6)
8647a61
@nzakas
Copy link
Member Author

nzakas commented Sep 1, 2020

Updating eslint-release solved this problem. 🎉 We can now use the latest package to fix eslint.

@nzakas nzakas closed this as completed Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nzakas nzakas

Labels
accepted bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Use specific git command to push eslint/eslint-release
1 participant
@nzakas