Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Replace usage of lodash with cache set #29

Merged
merged 1 commit into from
Feb 21, 2021

Conversation

TimvdLippe
Copy link
Contributor

As part of eslint/eslint#14098, remove
the single usage of lodash in this repository with an inlined
version of a cache set. As a result of this change, users of
ESLint will no longer accidentally include a second copy of
lodash in their node_modules tree.

As part of eslint/eslint#14098, remove
the single usage of `lodash` in this repository with an inlined
version of a cache set. As a result of this change, users of
ESLint will no longer accidentally include a second copy of
lodash in their `node_modules` tree.
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Nice job.

@btmills btmills changed the title Replace usage of lodash with cache set Chore: Replace usage of lodash with cache set Feb 20, 2021
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing!

@mdjermanovic mdjermanovic merged commit dac76c0 into eslint:main Feb 21, 2021
@TimvdLippe TimvdLippe deleted the remove-lodash-usage branch February 21, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants