Fix: Properly export module resolver

[Richienb]

relative-module-resolver.js does not provide a named export:

eslintrc/lib/shared/relative-module-resolver.js

Lines 17 to 44 in 62ea4bd

	module.exports = {
	/**
	* Resolves a Node module relative to another module
	* @param {string} moduleName The name of a Node module, or a path to a Node module.
	* @param {string} relativeToPath An absolute path indicating the module that `moduleName` should be resolved relative to. This must be
	* a file rather than a directory, but the file need not actually exist.
	* @returns {string} The absolute path that would result from calling `require.resolve(moduleName)` in a file located at `relativeToPath`
	*/
	resolve(moduleName, relativeToPath) {
	try {
	return createRequire(relativeToPath).resolve(moduleName);
	} catch (error) {
	// This `if` block is for older Node.js than 12.0.0. We can remove this block in the future.
	if (
	typeof error === "object" &&
	error !== null &&
	error.code === "MODULE_NOT_FOUND" &&
	!error.requireStack &&
	error.message.includes(moduleName)
	) {
	error.message += `\nRequire stack:\n- ${relativeToPath}`;
	}
	throw error;
	}
	}
	};

However it is still imported like so:

eslintrc/lib/index.js

Line 17 in 62ea4bd

const { ModuleResolver } = require("./shared/relative-module-resolver");

This PR fixes it by properly reexporting the fle. It is not a breaking change because even though the variable is renamed because the original name will still resolve with undefined.

[eslint-github-bot]

Hi @Richienb!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

• The commit message tag must be one of the following:

  The Tag is one of the following:

  • Fix - for a bug fix.
  • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
  • New - implements a new feature.
  • Breaking - for a backwards-incompatible enhancement or feature.
  • Docs - changes to documentation only.
  • Build - changes to build process only.
  • Upgrade - for a dependency upgrade.
  • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

  You can use the labels of the issue you are working on to determine the best tag.

• There should be a space following the initial tag and colon, for example 'New: Message'.

Read more about contributing to ESLint here

[eslint-github-bot]

Hi @Richienb!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

• The commit message tag must be one of the following:

  The Tag is one of the following:

  • Fix - for a bug fix.
  • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
  • New - implements a new feature.
  • Breaking - for a backwards-incompatible enhancement or feature.
  • Docs - changes to documentation only.
  • Build - changes to build process only.
  • Upgrade - for a dependency upgrade.
  • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

  You can use the labels of the issue you are working on to determine the best tag.

• There should be a space following the initial tag and colon, for example 'New: Message'.

Read more about contributing to ESLint here

[eslint-github-bot]

Hi @Richienb!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

• The commit message tag must be one of the following:

  The Tag is one of the following:

  • Fix - for a bug fix.
  • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
  • New - implements a new feature.
  • Breaking - for a backwards-incompatible enhancement or feature.
  • Docs - changes to documentation only.
  • Build - changes to build process only.
  • Upgrade - for a dependency upgrade.
  • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

  You can use the labels of the issue you are working on to determine the best tag.

• There should be a space following the initial tag and colon, for example 'New: Message'.

Read more about contributing to ESLint here

[eslint-github-bot]

Hi @Richienb!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

• The commit message tag must be one of the following:

  The Tag is one of the following:

  • Fix - for a bug fix.
  • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
  • New - implements a new feature.
  • Breaking - for a backwards-incompatible enhancement or feature.
  • Docs - changes to documentation only.
  • Build - changes to build process only.
  • Upgrade - for a dependency upgrade.
  • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

  You can use the labels of the issue you are working on to determine the best tag.

• There should be a space following the initial tag and colon, for example 'New: Message'.

Read more about contributing to ESLint here

[aladdin-add]

seems it's lacking of tests. can you add some tests? thx!

[aladdin-add]

LGTM, thanks!

[nzakas]

Agree with @mdjermanovic -- we should stick with the name ModuleResolver

[nzakas]

Note: We probably didn't catch this earlier because in ESLint we overwrite ModuleResolver to use the one in the ESLint repo.

[mdjermanovic]

Note: We probably didn't catch this earlier because in ESLint we overwrite ModuleResolver to use the one in the ESLint repo.

We're using this one, but with require("@eslint/eslintrc/lib/shared/relative-module-resolver"). When we release this fix, we could update that in the eslint/eslint repo.

[mdjermanovic]

LGTM, thanks!

[nzakas]

LGTM. Thanks.