Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm browserify #161

Merged
merged 1 commit into from
Jul 11, 2015
Merged

Conversation

jasonLaster
Copy link
Contributor

When I ran npm run browserify I got this error. The fix seemed to be to copy package.json into tmp. Have you seen this before?

➜  espree git:(cleanup-makefile) ✗ npm run browserify

> espree@2.0.4 browserify /Users/jlaster/src/_os/_js/espree
> node Makefile.js browserify

Error: Cannot find module './package.json' from '/Users/jlaster/src/_os/_js/espree/tmp'
    at /Users/jlaster/src/_os/_js/espree/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:55:21
    at load (/Users/jlaster/src/_os/_js/espree/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:69:43)
    at onex (/Users/jlaster/src/_os/_js/espree/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:92:31)
    at /Users/jlaster/src/_os/_js/espree/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:22:47

I also included some red npm test code because to the outsider it looks like you commented out your tests, whichi is not the case :)

@xjamundx
Copy link
Contributor

xjamundx commented Jul 8, 2015

oooh that looks cool. should fix #156 then

@nzakas
Copy link
Member

nzakas commented Jul 8, 2015

Looks good, can you please update the commit message to be in the form:

Fix: npm browserify (fixes #156)

Also, can you please sign our CLA? http://ESLint.org/cla

@jasonLaster
Copy link
Contributor Author

Sure.

@jasonLaster
Copy link
Contributor Author

done

ilyavolodin added a commit that referenced this pull request Jul 11, 2015
@ilyavolodin ilyavolodin merged commit 22e3875 into eslint:master Jul 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants