-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release 0.1.0 🚀 #2
Conversation
Hi @github-actions[bot]!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page. Read more about contributing to ESLint here |
package.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@eslint/json", | |||
"version": "0.0.1", | |||
"version": "1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it didn't respect "bump-minor-pre-major": true
option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's weird. I'll make another PR to reset the version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be because of the release-please action we're using.
In this repo, we're using google-github-actions/release-please-action@v4
. In the rewrite repo, we're using GoogleCloudPlatform/release-please-action@v4
. In other repos, e.g. espree, we're using google-github-actions/release-please-action@v3
.
google-github-actions/release-please-action
is deprecated in favor of googleapis/release-please-action@v4
.
There seem to be a lot of different versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, had no idea all that was going on. I guess we should standardize on the new version.
df13ac5
to
18f1bda
Compare
Hi @github-actions[bot]!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page. Read more about contributing to ESLint here |
1 similar comment
Hi @github-actions[bot]!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page. Read more about contributing to ESLint here |
18f1bda
to
6218fcc
Compare
Hi @github-actions[bot]!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page. Read more about contributing to ESLint here |
1 similar comment
Hi @github-actions[bot]!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page. Read more about contributing to ESLint here |
Looks like |
Looks like a known bug: googleapis/release-please-action#952 I think this will work: #5 |
6218fcc
to
7719bad
Compare
Hi @github-actions[bot]!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page. Read more about contributing to ESLint here |
1 similar comment
Hi @github-actions[bot]!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page. Read more about contributing to ESLint here |
Nope again, it seems determined to release v1.0.0. |
Maybe #6 could help. |
Note that it didn't update |
7719bad
to
1703631
Compare
Hi @github-actions[bot]!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page. Read more about contributing to ESLint here |
1 similar comment
Hi @github-actions[bot]!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page. Read more about contributing to ESLint here |
This is bizarre. I have a similar setup in a person repo without any problems. Going to investigate now. |
Maybe this will work: #7 |
1703631
to
637a902
Compare
It fixed the problem 🎉 Just it looks like the pattern should be updated a bit. |
637a902
to
60286d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good now. Just not sure if we should wait for eslint v9.7.0 (with eslint/eslint@6320732) before releasing this.
Because we aren't using any selectors, I think it's okay to release. I'm not going to make a formal announcement until next week anyway, but I'd like to ensure the release process works and get this integrated into |
🤖 Created releases: |
🤖 I have created a release beep boop
0.1.0 (2024-07-06)
Features
Bug Fixes
This PR was generated with Release Please. See documentation.