Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue since change on deno polyfill #27

Closed
RoXuS opened this issue Mar 8, 2021 · 9 comments
Closed

Issue since change on deno polyfill #27

RoXuS opened this issue Mar 8, 2021 · 9 comments

Comments

@RoXuS
Copy link

RoXuS commented Mar 8, 2021

Hey team,

Since change on deno polyfill (last commits) we have an issue when we use our package from esm:

image

Example of usages:
export { parseStringPromise } from "https://esm.sh/xml2js@0.4.23";

@RoXuS
Copy link
Author

RoXuS commented Mar 8, 2021

any way to stay on v15?

Something like this
export { parseStringPromise } from "https://esm.sh/v15/xml2js@0.4.23";

@shadowtime2000
Copy link

@RoXuS Try importing from like https://cdn.esm.sh/v15/xml2js@0.4.23 or something like that

@RoXuS
Copy link
Author

RoXuS commented Mar 8, 2021

yeah it is ok with v15!

@RoXuS
Copy link
Author

RoXuS commented Mar 8, 2021

But we have to focus the file directly

https://cdn.esm.sh/v15/xml2js@0.4.23 -> redirect to v16
https://cdn.esm.sh/v15/xml2js@0.4.23/esnext/xml2js.js -> ok on v15 (but types are KO)

@ije
Copy link
Member

ije commented Mar 9, 2021

i will revert the v15's polyfills since the deno/std/node is not stable.

@RoXuS
Copy link
Author

RoXuS commented Mar 9, 2021

i will revert the v15's polyfills since the deno/std/node is not stable.

you can't enable v15 and v16 at same time?

ije added a commit that referenced this issue Mar 13, 2021
@ije
Copy link
Member

ije commented Mar 13, 2021

i just disabled the events polyfill of std/node, please try again deno --reload

@RoXuS
Copy link
Author

RoXuS commented Mar 13, 2021

I get
image

During aleph build...

@ije
Copy link
Member

ije commented Mar 15, 2021

fixed

@ije ije closed this as completed Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants