Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conditions: "development" for ?dev imports #375

Closed
milomg opened this issue Jul 22, 2022 · 1 comment
Closed

Add conditions: "development" for ?dev imports #375

milomg opened this issue Jul 22, 2022 · 1 comment
Labels
browser Not working in Browser

Comments

@milomg
Copy link

milomg commented Jul 22, 2022

First of all, thanks for creating an awesome and fast tool! I'm looking at using it inside the SolidJS playground and it is super useful!

One issue I ran into was SolidJS uses different node conditions and already builds dev versions of the package, exported using the development condition for dev mode. It would be great if ?dev could automatically add that condition, but I thought I would check if that was wanted here before submitting a PR.

Failing module

import { something } from 'https://esm.sh/solid-js?dev'

Result

Searching the resulting bundle for console.warn doesn't yield anything (compare with https://cdn.jsdelivr.net/npm/solid-js@1.4.7/dist/dev.js)

Additional info

  • esm.sh version: v87
@milomg milomg added the browser Not working in Browser label Jul 22, 2022
@ije
Copy link
Member

ije commented Jul 28, 2022

close in 049c2ba

@ije ije closed this as completed Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser Not working in Browser
Projects
None yet
Development

No branches or pull requests

2 participants