named exports are missing

[trusktr]

import('https://esm.sh/@lume/element').then(({Element}) => {
  console.log(Element)
})

results in logging undefined instead of the expected value.

Note that the @lume/element package follows modern ESM standards and it works in Node.js ESM, or any tools that strictly follow Node ESM standards (like Webpack 5+).

Here's what the entry looks like: https://unpkg.com/@lume/element

[zhoukekestar]

Because esm.sh get named export by using node to eval your package.
You can get more details with fellow links:

• https://github.com/postui/esm.sh/blob/master/server/build.go#L290
• Export commonjs named exports in ESM evanw/esbuild#442

And your @lume/package/dist/LumeElement use window object which will cause the eval fail.

Maybe we should try another way to get package's named export, puppeteer or something browser-like environment instead of node eval.

[trusktr]

Yeah, it is a browser lib that uses window.

I think if the aim is to support ESM, the exports should be statically extracted without having to run the module. That's the whole benefit of ESM static imports (but not import() function).

Random ideas: use Babel or TypeScript compilers to get an AST, then read the exports from there. That would be a more realistic way to do it I think. It would not require running any code (that can be left to the end user to decide where they will run the code).

[ije]

@trusktr thanks, yes you are right, i have a plan to rewrite the peer.js using AST to get right export names, but too busy currently...in fact there was a PR #33 to try to fix this but will affect other packages so i reverted. any way i will fix it ASAP

[ije]

fixed, pls try again, thanks~