-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/medusa #757
Feat/medusa #757
Conversation
Hi Ying, I have fixed a very small bug in there. For now my only comment is that I am failing to compile in the very last step of the compilation command (
Do you know how to solve that? |
Hi Miguel, I see your fix...thanks. |
I tested and pushed the changes to the medusa repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing tests seem to be incorrect "truth" for awicm3. Otherwise, since I am the second person doing support today, this gets a green light from me :-)
Some small comments which are not really important but might be "nice to have" are included below.
I'm going to turn this from a draft to an actual ready-to-go PR. If there are reasons against that, just let me know. |
This is still missing some work, for example cleaning up comments, and making sure we add a compilation test to |
…till not properly linking netcf
…tarts, or output copying
#approve-changes |
#bump |
Compilation of the medusa model and our application was tested. Directories like 'code_dir' and 'lib_dir' defined before the comp_command part can not be used in the comp_command block.