Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/medusa #757

Merged
merged 69 commits into from
Aug 25, 2023
Merged

Feat/medusa #757

merged 69 commits into from
Aug 25, 2023

Conversation

a270105
Copy link
Collaborator

@a270105 a270105 commented Aug 1, 2022

Compilation of the medusa model and our application was tested. Directories like 'code_dir' and 'lib_dir' defined before the comp_command part can not be used in the comp_command block.

@a270105 a270105 requested a review from mandresm August 1, 2022 14:27
@mandresm
Copy link
Contributor

mandresm commented Aug 2, 2022

Hi Ying,

I have fixed a very small bug in there. For now my only comment is that I am failing to compile in the very last step of the compilation command (cd /home/ollie/mandresm/direnv_test_6.7.0/medusa-2.0/medmbm/trunk4mcg/apps/medusa_recom_awiesm; make;) with the following error:

mpiifort -DDEBUG -DCALENDAR_360DAYS  -W0 -WB -convert big_endian -assume byterecl -fPIC -align -O3 -no-prec-div -fp-model fast=2 -xHost -I/global/AWIsoft/netcdf/4.6.1_intel_18.0.3/include -I./modmedusa -I. store_nc_aux.o store_csv_summary.o mod_timecont_medusa_tsi.o mod_recom_paleo_medusa_setup.o mod_recom_paleo_o2s.o mod_recom_paleo_s2o.o mod_files_medusa.o medusa_recom_paleo.o \
-L. -lmedusa  -L/global/AWIsoft/netcdf/4.6.1_intel_18.0.3/lib -lnetcdf -lnetcdff  -L/home/ollie/mandresm/medusa2019/lib/mpiifort -lthdyct -o medusa_recom_paleo.20220802143409
ld: cannot find -lthdyct
make[1]: *** [medusa_recom_paleo] Error 1
make[1]: Leaving directory `/home/ollie/mandresm/direnv_test_6.7.0/medusa-2.0/medmbm/trunk4mcg/apps/medusa_recom_awiesm'
make: *** [wno3] Error 2

Do you know how to solve that?

@a270105
Copy link
Collaborator Author

a270105 commented Aug 2, 2022

Hi Miguel, I see your fix...thanks.
And yes, I know how to fix the problem with the missing libthdyct.a. I will push my changes in the library makefile in some minutes

@a270105
Copy link
Collaborator Author

a270105 commented Aug 2, 2022

I tested and pushed the changes to the medusa repository

@pgierz pgierz self-requested a review August 5, 2022 08:10
Copy link
Member

@pgierz pgierz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing tests seem to be incorrect "truth" for awicm3. Otherwise, since I am the second person doing support today, this gets a green light from me :-)

Some small comments which are not really important but might be "nice to have" are included below.

@pgierz
Copy link
Member

pgierz commented Aug 5, 2022

I'm going to turn this from a draft to an actual ready-to-go PR. If there are reasons against that, just let me know.

@pgierz pgierz marked this pull request as ready for review August 5, 2022 08:14
@mandresm
Copy link
Contributor

mandresm commented Aug 5, 2022

This is still missing some work, for example cleaning up comments, and making sure we add a compilation test to esm_tests. But it's okay to leave it as non-draft. I'm meeting with Ying on monday to discuss next steps.

@mandresm
Copy link
Contributor

#approve-changes

@mandresm
Copy link
Contributor

#bump

@mandresm mandresm merged commit 143436b into release Aug 25, 2023
@mandresm mandresm deleted the feat/medusa branch August 25, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants