Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-213: Related ADO cache tag invalidation #214

Merged
merged 3 commits into from
Mar 30, 2022
Merged

ISSUE-213: Related ADO cache tag invalidation #214

merged 3 commits into from
Mar 30, 2022

Conversation

DiegoPino
Copy link
Member

See #213

Also includes PHP8 (smaller) fixes and a more flexible dependencies matrix

This uses an EvenSubscriber that tries to run as late as possible and makes also use of our Computed Entity Reference field ->field_sbf_nodetonode to fetch previous (if not new) and new referenced ADOs/NODEs to invalidate their caches. Did some tests and all seems to work well. Will of course test more
I need to do this better (and be better at). Remember people optional arguments can not be followed by required ones. Its PHP 101...
Since composer.lock will still give us good check
@DiegoPino DiegoPino self-assigned this Mar 10, 2022
@DiegoPino DiegoPino added enhancement New feature or request Events and Subscriber PHP8 The one that comes after 7 Symfony Services labels Mar 10, 2022
@DiegoPino DiegoPino added this to the 1.0.0 milestone Mar 10, 2022
@DiegoPino DiegoPino merged commit 41153fb into 1.0.0 Mar 30, 2022
@DiegoPino DiegoPino deleted the ISSUE-213 branch March 30, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Events and Subscriber PHP8 The one that comes after 7 Symfony Services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant