ISSUE-222: Composer bin service. Enqueue and delete temp files #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds: - New Event Type - New Event Subscriber for Temp Files - Settings for time to live - Queue worker - Small adaptations (Some of this depends on D9 but i do not want to leave people behind so might as well double test on D8, that is why i use complete classes and check if they exist) - Event dispatch when and ADO File is copied into final destination - Schema update
DiegoPino
added
enhancement
aksm
reviewed
May 19, 2022
Totally! Thanks Co-authored-by: Albert Min <albert.min@gmail.com>
|
Hi @DiegoPino , I'm just catching up on your amazing work. I absolutely ❤️ this! Thank you so much! Initial testing seems to be good. The only fly in the ointment that I see is that for temporary AMI files it leaves the empty directories. I'm not sure if there's an easy solution for that. After the $this->filesystem->delete($uri), might it make sense to check to see if there are any remaining files in the deleted file's parent directory, and if not, remove the directory? |
|
Interesting! Good catch. Yes, that is a good idea. Can you open an issue? I can code that. Thanks so much. Also, maybe we should add an extra option that is lower than 6 hours? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #222
This pull adds:
/admin/config/archipelago/filepersistingThe queue needs to be configured to Run hopefully using Hydroponics but testing can be also done via the System Queue manager.
Other modules (e.g SB Flavors) will invoke the event too to mark its own temps are "compostable"♻️
@patdunlavey @alliomeria @aksm @giancarlobi If any of you see anything strange in the code let me know?