add igonre table config for show#tables #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have prepared the settings that you can specify the table name that you do not want to appear in the table list. For example, ``` config.ignore_table_names = %w(SecretTable) ``` The specified table will not appear in the table list.
|
Hmmm, ActiveRecord class IS NOT identical with tables. I'm wondering the things we want to hide(or ignore) is whether table or AR model. If you use |
|
My opinion of option name
|
| @ar_classes = ActiveRecord::Base.subclasses. | ||
| reject {|klass| klass.name == 'ActiveRecord::SchemaMigration' }. | ||
| reject {|klass| ignore_table_names.include?(klass.name) }. |
There was a problem hiding this comment.
I think that abstract_class model should be filtered too.
There was a problem hiding this comment.
create new issue. #71
It sounds good. How do you think about this? @takkanm |
me too. thx @joker1007 . |
|
LGTM 👍 |
moro
added a commit
that referenced
this pull request
Sep 9, 2015
add igonre table config for show#tables
takkanm
added a commit
that referenced
this pull request
Oct 15, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have prepared the settings that you can specify the table name that
you do not want to appear in the table list.
For example,
The specified table will not appear in the table list.