Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocessor generality #40

Closed
ledm opened this issue Mar 13, 2019 · 3 comments
Closed

Preprocessor generality #40

ledm opened this issue Mar 13, 2019 · 3 comments
Assignees
Labels
preprocessor Related to the preprocessor

Comments

@ledm
Copy link
Contributor

ledm commented Mar 13, 2019

Some preprocessors like zonal_mean and area_average have recently (#825) been expanded to allow more generic operation beyond just a simple mean. This means that while they're called mean or average, they can also do medians, standard deviations, variance, etc.

It would be great to add this functionality to the other spatial and temporal preprocessors:

  • average_volume
  • seasonal_mean
  • time_average

While we're there, we should also change zonal_mean's argument from mean_type to operation to match average_region.

We wouldn't even need to change our recipes if we kept the current preprocessors names like zonal_mean or average_volume as special cases of the more generic functions.

@ledm ledm self-assigned this Mar 13, 2019
@mattiarighi mattiarighi transferred this issue from ESMValGroup/ESMValTool Jun 11, 2019
@mattiarighi mattiarighi added the preprocessor Related to the preprocessor label Jun 11, 2019
@jvegreg
Copy link
Contributor

jvegreg commented Aug 28, 2019

#87 is doing this for time related functions

@mattiarighi
Copy link
Contributor

I think this is solved, @ledm ?

@ledm
Copy link
Contributor Author

ledm commented May 27, 2020

Yes!

@ledm ledm closed this as completed May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preprocessor Related to the preprocessor
Projects
None yet
Development

No branches or pull requests

3 participants