Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redirect on login #17

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Fix redirect on login #17

merged 2 commits into from
Sep 10, 2024

Conversation

jomority
Copy link
Contributor

The $QUERY variable seems to contain nothing.

Reading the GET parameter id works for me, even with the userewrite configuration option enabled.

auth.php Outdated Show resolved Hide resolved
auth.php Outdated Show resolved Hide resolved
@dgeo
Copy link
Collaborator

dgeo commented Apr 14, 2020

In my understanding, logout doesn't need this (or I'm missing something)

@phy25
Copy link
Contributor

phy25 commented Apr 14, 2020

@dgeo I am not sure what your "this" means, but DokuWiki will redirect with current $ID when logging out:

https://github.com/splitbrain/dokuwiki/blob/31a58aba4c24b34c34ad5764d1a35b7c398c3a2c/inc/Action/Logout.php#L43-L44

Co-Authored-By: Henry Pan <github@phy25.com>
Copy link
Collaborator

@dgeo dgeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested here and kept :)

@phy25 phy25 mentioned this pull request Jan 21, 2021
@dgeo
Copy link
Collaborator

dgeo commented Jul 4, 2023

may we merge this ?
(can I help maintaining ?)

@dgeo dgeo merged commit fb155e7 into esn-org:master Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants