This repository has been archived by the owner on Feb 22, 2020. It is now read-only.
Close and delete the socket if connect() fails #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a failed
connect()
,is_connected()
oddly returnsTrue
, and aquery()
will attempt to write to the socket, even though that's hardly going to work at that point.Attempting a second
connect()
raisesumysql.Error(0, "Socket already connected")
, but after that,is_connected()
returnsFalse
again, and we're back where we started.I'm basically a blind monkey banging away at the C++ typewriter here, but my best guess was to close and delete the socket when
connect()
fails. It doesn't seem to have caused a global thermonuclear war. Yet.