Skip to content
This repository has been archived by the owner on Feb 22, 2020. It is now read-only.

Use standard unix style file-separator in Manifest.in #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lonetwin
Copy link

@lonetwin lonetwin commented Oct 6, 2015

The current backslash separator in Manifest.in does not allow creation of source distributions / rpms on linux. Changing this to the more standard forward slash fixes this issue. ie:

before this change:

[steve@localhost ~/src/ultramysql (master)]$ python setup.py sdist
running sdist
running check
reading manifest template 'MANIFEST.in'
warning: no files found matching 'python\*.c'
warning: no files found matching 'python\*.h'
warning: no files found matching 'lib\*.cpp'
warning: no files found matching 'lib\*.h'
writing manifest file 'MANIFEST'
creating umysql-2.61
...
...
Creating tar archive
removing 'umysql-2.61' (and everything under it)

after this change:

[steve@localhost ~/src/ultramysql (master)]$ python setup.py sdist
running sdist
running check
reading manifest template 'MANIFEST.in'
writing manifest file 'MANIFEST'
creating umysql-2.61
creating umysql-2.61/lib
creating umysql-2.61/python
making hard links in umysql-2.61...
hard linking LICENSE -> umysql-2.61
hard linking README -> umysql-2.61
hard linking setup.py -> umysql-2.61
hard linking ./lib/Connection.cpp -> umysql-2.61/./lib
hard linking ./lib/PacketReader.cpp -> umysql-2.61/./lib
hard linking ./lib/PacketWriter.cpp -> umysql-2.61/./lib
hard linking ./lib/SHA1.cpp -> umysql-2.61/./lib
hard linking ./lib/capi.cpp -> umysql-2.61/./lib
hard linking ./python/io_cpython.c -> umysql-2.61/./python
hard linking ./python/umysql.c -> umysql-2.61/./python
hard linking lib/Connection.h -> umysql-2.61/lib
hard linking lib/PacketReader.h -> umysql-2.61/lib
hard linking lib/PacketWriter.h -> umysql-2.61/lib
hard linking lib/SHA1.h -> umysql-2.61/lib
hard linking lib/mysqldefs.h -> umysql-2.61/lib
hard linking lib/socketdefs.h -> umysql-2.61/lib
hard linking python/umysql.h -> umysql-2.61/python
Creating tar archive
removing 'umysql-2.61' (and everything under it)

The current backslash separator in Manifest.in does not allow creation of source distributions / rpms on linux. Changing this to the more standard forward slash fixes this issue. ie:

before this change:

```
[steve@localhost ~/src/ultramysql (master)]$ python setup.py sdist
running sdist
running check
reading manifest template 'MANIFEST.in'
warning: no files found matching 'python\*.c'
warning: no files found matching 'python\*.h'
warning: no files found matching 'lib\*.cpp'
warning: no files found matching 'lib\*.h'
writing manifest file 'MANIFEST'
creating umysql-2.61
...
...
Creating tar archive
removing 'umysql-2.61' (and everything under it)

```

after this change:

```
[steve@localhost ~/src/ultramysql (master)]$ python setup.py sdist
running sdist
running check
reading manifest template 'MANIFEST.in'
writing manifest file 'MANIFEST'
creating umysql-2.61
creating umysql-2.61/lib
creating umysql-2.61/python
making hard links in umysql-2.61...
hard linking LICENSE -> umysql-2.61
hard linking README -> umysql-2.61
hard linking setup.py -> umysql-2.61
hard linking ./lib/Connection.cpp -> umysql-2.61/./lib
hard linking ./lib/PacketReader.cpp -> umysql-2.61/./lib
hard linking ./lib/PacketWriter.cpp -> umysql-2.61/./lib
hard linking ./lib/SHA1.cpp -> umysql-2.61/./lib
hard linking ./lib/capi.cpp -> umysql-2.61/./lib
hard linking ./python/io_cpython.c -> umysql-2.61/./python
hard linking ./python/umysql.c -> umysql-2.61/./python
hard linking lib/Connection.h -> umysql-2.61/lib
hard linking lib/PacketReader.h -> umysql-2.61/lib
hard linking lib/PacketWriter.h -> umysql-2.61/lib
hard linking lib/SHA1.h -> umysql-2.61/lib
hard linking lib/mysqldefs.h -> umysql-2.61/lib
hard linking lib/socketdefs.h -> umysql-2.61/lib
hard linking python/umysql.h -> umysql-2.61/python
Creating tar archive
removing 'umysql-2.61' (and everything under it)
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant