refactor: Create removeArrayElByKey utility

Author: becem-gharbi

composables/useDeployment.ts

@@ -40,13 +40,7 @@ export default function useDeployment (deviceId: Device['id']) {
 
       onResponse: ({ response }) => {
         if (response.ok && deployments.data.value) {
-          const deploymentIndex = deployments.data.value.findIndex(
-            deployment => deployment.id === id
-          )
-
-          if (deploymentIndex >= 0) {
-            deployments.data.value.splice(deploymentIndex, 1)
-          }
+          removeArrayElByKey(deployments.data.value, 'id', id)
         }
       }
     })
@@ -83,13 +77,7 @@ export default function useDeployment (deviceId: Device['id']) {
 
   function removeByRelease (releaseId: Release['id']) {
     if (deployments.data.value) {
-      const deploymentIndex = deployments.data.value.findIndex(
-        deployment => deployment.releaseId === releaseId
-      )
-
-      if (deploymentIndex >= 0) {
-        deployments.data.value.splice(deploymentIndex, 1)
-      }
+      removeArrayElByKey(deployments.data.value, 'releaseId', releaseId)
     }
   }
 

composables/useDevice.ts

@@ -29,13 +29,7 @@ export default function useDevice () {
 
       onResponse: ({ response }) => {
         if (response.ok && devices.data.value) {
-          const deviceIndex = devices.data.value.findIndex(
-            device => device.id === id
-          )
-
-          if (deviceIndex >= 0) {
-            devices.data.value.splice(deviceIndex, 1)
-          }
+          removeArrayElByKey(devices.data.value, 'id', id)
         }
 
         if (response.ok) {

composables/useProject.ts

@@ -29,12 +29,7 @@ export default function useProject () {
 
       onResponse: ({ response }) => {
         if (response.ok && projects.data.value) {
-          const projectIndex = projects.data.value.findIndex(
-            project => project.id === id
-          )
-          if (projectIndex >= 0) {
-            projects.data.value.splice(projectIndex, 1)
-          }
+          removeArrayElByKey(projects.data.value, 'id', id)
         }
 
         if (response.ok) {

composables/useRelease.ts

@@ -27,12 +27,7 @@ export default function useRelease (projectId: Project['id']) {
 
       onResponse: async ({ response }) => {
         if (response.ok && releases.data.value) {
-          const releaseIndex = releases.data.value.findIndex(
-            release => release.id === id
-          )
-          if (releaseIndex >= 0) {
-            releases.data.value.splice(releaseIndex, 1)
-          }
+          removeArrayElByKey(releases.data.value, 'id', id)
         }
 
         if (response.ok) {

utils/array.ts

@@ -0,0 +1,12 @@
+/**
+ * Removes element from array having a certain value for a giving key
+ */
+export function removeArrayElByKey (array: Array<Record<string, any>>, key: string, value: any) {
+  const index = array.findIndex(
+    el => el[key] === value
+  )
+
+  if (index >= 0) {
+    array.splice(index, 1)
+  }
+}