Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCAD Update for print 2 #19

Merged
merged 1 commit into from
Feb 18, 2023
Merged

MCAD Update for print 2 #19

merged 1 commit into from
Feb 18, 2023

Conversation

finger563
Copy link
Contributor

Description

  • Made A key non-reversible (so it can't be put in upside down)
  • Made X key reversible (since it can be put in upside down)
  • Increased spacing between button bottom plates and their shrouds in the top housing
  • Closed off the housing around the esp32-s3-box and the PCB so that it will look cleaner when assembled (without the s3 box in it) and so that it will not leak as much button sound.
  • Added mating pins to the top/bottom housings around the esp32-s3-box so that it will press-fit together nicely and align better

Motivation and Context

Some final quality of life improvements (for assembly and look/feel) before 2nd print.

How has this been tested?

It hasn't yet - just done some interference analysis before printing it :)

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

CleanShot 2023-02-18 at 14 03 36
CleanShot 2023-02-18 at 14 04 09
CleanShot 2023-02-18 at 14 04 27
CleanShot 2023-02-18 at 14 04 53

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Hardware

  • I have updated the design files (schematic, board, libraries).
  • I have attached the PDFs of the SCH / BRD to this PR
  • I have updated the design output (GERBER, BOM) files.
  • I have updated the MCAD (stl) files

…-reversible. closed off housing around pcb and esp32-s3-box and added some pins to mate the top/bottom housing together in the sides around the esp32-s3-box.
@finger563 finger563 added enhancement New feature or request hardware labels Feb 18, 2023
@finger563 finger563 changed the title MCAD Update for print MCAD Update for print 2 Feb 18, 2023
@finger563 finger563 merged commit 8c9a3d5 into main Feb 18, 2023
@finger563 finger563 deleted the feature/mcad-update branch February 18, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hardware
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant