Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SIMD acceleration for JPEGDEC component #86

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

finger563
Copy link
Contributor

Description

  • Update to use esp-cpp/jpegdec fork with fix for s3 simd build config
  • Add compile definition to enable s3 simd acceleration

Motivation and Context

The latest JPEGDEC component supports SIMD accelerated decoding, and we'd like to use it to increase the performance of the main menu with the rom boxart loading :)

Related PR on JPEGDEC: bitbank2/JPEGDEC#82

How has this been tested?

Building and running with the updated config, measuring jpeg decoding performance before and after

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

jpegdec_simd_acceleration.xlsx
test_no_simd.csv
test_with_simd.csv

CleanShot 2024-08-11 at 21 35 26@2x

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 self-assigned this Aug 12, 2024
@finger563 finger563 merged commit 1aac948 into main Aug 12, 2024
3 checks passed
@finger563 finger563 deleted the jpegdec/enable-simd-acceleration branch August 12, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant