-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate TIMG into timer0, (timer1), wdt #104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good overall, thanks for doing this! Just left a few little comments, and I'd also prefer not to include the VS Code config files as mentioned in the other PR.
Co-authored-by: Jesse Braham <jessebraham@users.noreply.github.com>
@jessebraham tackled the comments for I kept the chip-specific settings since they usually don't change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those changes!
* Separate TIMG into timer0, (timer1), wdt * Apply suggestions from code review * Remove left-over code * Ignore settings.json
TimerGroup
which is split into timer0, (timer1) and wdttimer_interrupt
example for Xtensa based chips to use 4 timersThere is some level of duplicated code but the only alternative would be another macro. Since working with macros isn't really convenient, I accepted the duplicated code here. If we had more timers a macro might be worth it but I think in this case the duplication is acceptable
THIS IS A BREAKING CHANGE!
Better to do this sooner than later
This looks like a huge PR but it's not as bad as it looks like since every example had to be changed.
One note: The Xtensa based chips seem to have three timers in each timer group (called LACT on ESP32) but the TRM and also apparently ESP-IDF only ever talk about two. If we ever decide to add that mysterious third timer the change shouldn't affect most user code. So going with two timers now