Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packages
command to ensure that all changed code is formatted correctly.CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
Description
Adds a single HIL test for the PCNT peripheral.
I was planning to write more tests but the PCNT driver is bit difficult to use, it asks for too much config upfront and lacks reasonable defaults. I'm writing a PR to make improvements to the API and it'll come with more HIL tests.
For my SPI DMA move API changes, I figured it'd be handy to write some half duplex HIL tests to help verify my changes.
For half duplex writes, I figured the PCNT peripheral would be handy to count the mosi movements.
Before writing the half duplex tests, I figured having some simple PCNT tests to begin with would be best for my sanity.
No changelog for HIL tests
Testing
CI