Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PCNT HIL test #1746

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Add PCNT HIL test #1746

merged 1 commit into from
Jul 4, 2024

Conversation

Dominaezzz
Copy link
Collaborator

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

Adds a single HIL test for the PCNT peripheral.
I was planning to write more tests but the PCNT driver is bit difficult to use, it asks for too much config upfront and lacks reasonable defaults. I'm writing a PR to make improvements to the API and it'll come with more HIL tests.

For my SPI DMA move API changes, I figured it'd be handy to write some half duplex HIL tests to help verify my changes.
For half duplex writes, I figured the PCNT peripheral would be handy to count the mosi movements.
Before writing the half duplex tests, I figured having some simple PCNT tests to begin with would be best for my sanity.

No changelog for HIL tests

Testing

CI

@Dominaezzz Dominaezzz marked this pull request as ready for review July 4, 2024 00:57
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! More test coverage is great

@bjoernQ
Copy link
Contributor

bjoernQ commented Jul 4, 2024

For half duplex writes, I figured the PCNT peripheral would be handy to count the mosi movements.

Good idea. I thought about using RMT to implement such a test. I also tried to come up with a bit-banged I2C master test but that is a bit tricky - probably should try a little harder 😄

Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JurajSadel JurajSadel added this pull request to the merge queue Jul 4, 2024
Merged via the queue into esp-rs:main with commit c62bd8b Jul 4, 2024
30 checks passed
@Dominaezzz Dominaezzz deleted the pcnt_hil branch July 4, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants