Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esp32s3: usb-serial-jtag interrupt #664

Merged
merged 2 commits into from
Jul 19, 2023
Merged

esp32s3: usb-serial-jtag interrupt #664

merged 2 commits into from
Jul 19, 2023

Conversation

MabezDev
Copy link
Member

@MabezDev MabezDev commented Jul 19, 2023 •
edited
Loading

  • Fix not reading the last interrupt status register on esp32s3, this happens to be where the USB-SERIAL-JTAG interrupt is kept.
  • Fix disable() on Xtensa, according to the TRM to disable a peripheral interrupt, it must be mapped to a CPU peripheral interrupt not zero.

Closes #633

Thank you!

Thank you for your contribution.
Please make sure that your submission includes the following:

Must

  • The code compiles without errors or warnings.
  • All examples work.
  • cargo fmt was run.
  • Your changes were added to the CHANGELOG.md in the proper section.
  • You updated existing examples or added examples (if applicable).
  • Added examples are checked in CI

Nice to have

  • You add a description of your work to this PR.
  • You added proper docs for your newly added features and code.

@MabezDev
esp32s3: usb-serial-jtag interrupt
488aba7 
- Fix not reading the last interrupt status register on esp32s3, this
  happens to be where the USB-SERIAL-JTAG interrupt is kept.
- Fix `disable()` on Xtensa, according to the TRM to disable a
  peripheral interrupt, it must be mapped to a CPU peripheral interrupt
  not zero.
@MabezDev
Add changelog.md
f0a9048
jessebraham
jessebraham approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jessebraham jessebraham merged commit 28ac202 into esp-rs:main Jul 19, 2023
15 checks passed
@MabezDev MabezDev mentioned this pull request Jul 20, 2023
Merged
playfulFence pushed a commit to playfulFence/esp-hal that referenced this pull request Sep 26, 2023
@MabezDev @playfulFence
esp32s3: usb-serial-jtag interrupt (esp-rs#664)
7f50bdf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebraham jessebraham jessebraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Troubles with USB Serial/JTAG on ESP32-S3 chip.
2 participants
@MabezDev @jessebraham