Fix UART to handle CPU/APB clock changes #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
force-pushed
the
uart-init-clocks
branch
2 times, most recently
from
e92d74c
to
344d9d1
Compare
bjoernQ
reviewed
Sep 21, 2023
MabezDev
force-pushed
the
uart-init-clocks
branch
from
344d9d1
to
ef96277
Compare
bugadani
reviewed
Sep 21, 2023
MabezDev
force-pushed
the
uart-init-clocks
branch
from
ef96277
to
79549a2
Compare
MabezDev
commented
Sep 21, 2023
| } | ||
| use crate::gpio::*; | ||
| // not real, just to satify the type | ||
| type Pins<'a> = TxRxPins<'a, GpioPin<Output<PushPull>, 2>, GpioPin<Input<Floating>, 0>>; |
There was a problem hiding this comment.
If anyone has a better idea of how to satisfy this let me know.
This was referenced Sep 21, 2023
SergioGasquez
pushed a commit
to SergioGasquez/esp-hal
that referenced
this pull request
Sep 22, 2023
* Ensure that uart is configured to account for clock changes, not just boot defaults * fix examples * changelog --------- Co-authored-by: Jesse Braham <jessebraham@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the ESP32 and ESP32-S2, baud rate can be affected by CPU speed, which was causing issues in the stub: esp-rs/esp-flasher-stub#29 ( and perhaps some esp-wifi projects?).
newnow takes a reference to the CPU clock and adjusts its baud calculations accordingly.Must
errorsorwarnings.cargo fmtwas run.CHANGELOG.mdin the proper section.Nice to have