-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous pre-release fixes #883
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided that the naming of the interrupt stuff on alarms would be verb_noun
, so we reverted to enable_alarm
, but interrupt_clear
didn't get changed (it should be clear_interrupt
).
Ahh yeah thanks, this was previously brought to my attention but nobody opened an issue for that so it got forgotten. Will get that fixed shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
* Temporarily disable async `SYSTIMER` implementation, remove mention from `CHANGELOG.md` * Remove a couple files which are not required * Fix warning for `sha` examples * Fix warning for non-C3 devices * s/interrupt_clear/clear_interrupt/
embedded_hal_async::delay::DelayMs
implementationesp-wifi
asynch
module via a#[cfg()]
, rather than removing the implementation altogether, as it is a valid implementation.sha
examplesSYSTIMER
'sinterrupt_clear
function toclear_interrupt
I think this should put us in decent shape for our next round of releases. @MabezDev @bjoernQ lemme know if you can think of anything I'm forgetting, please.