Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous pre-release fixes #883

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Conversation

jessebraham
Copy link
Member

@jessebraham jessebraham commented Oct 30, 2023

  • Temporarily disable the embedded_hal_async::delay::DelayMs implementation
    • This was causing issues with esp-wifi
    • I've just disabled the entire asynch module via a #[cfg()], rather than removing the implementation altogether, as it is a valid implementation.
  • Remove a couple of old files which are not required
  • Fix build warnings for sha examples
  • Fix build warning when not targeting ESP32-C3
  • Rename SYSTIMER's interrupt_clear function to clear_interrupt

I think this should put us in decent shape for our next round of releases. @MabezDev @bjoernQ lemme know if you can think of anything I'm forgetting, please.

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided that the naming of the interrupt stuff on alarms would be verb_noun, so we reverted to enable_alarm, but interrupt_clear didn't get changed (it should be clear_interrupt).

@jessebraham
Copy link
Member Author

jessebraham commented Oct 31, 2023

Ahh yeah thanks, this was previously brought to my attention but nobody opened an issue for that so it got forgotten. Will get that fixed shortly.

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jessebraham jessebraham merged commit 9cb8f7e into esp-rs:main Oct 31, 2023
17 checks passed
@jessebraham jessebraham deleted the fixes/misc branch October 31, 2023 13:54
katyo pushed a commit to katyo/esp-hal that referenced this pull request Nov 6, 2023
* Temporarily disable async `SYSTIMER` implementation, remove mention from `CHANGELOG.md`

* Remove a couple files which are not required

* Fix warning for `sha` examples

* Fix warning for non-C3 devices

* s/interrupt_clear/clear_interrupt/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants