fix clock usage in timer driver for idf 5 #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivmarkov
reviewed
Jun 20, 2024
|
|
||
| #[cfg(not(esp_idf_version_major = "4"))] | ||
| #[allow(clippy::upper_case_acronyms)] | ||
| pub(crate) enum ClockSource { |
There was a problem hiding this comment.
Tbh i dont like our current clocktree api design, or lag of it. So this is more of a stopgab solution, till we have a general better api for that sort of stuff. Thats why i didn't want to expose it into public api.
There was a problem hiding this comment.
I meant why is it with a crate visibility and not private, but then again - just a nit.
src/timer.rs
Outdated
| } | ||
|
|
||
| #[cfg(not(esp_idf_version_major = "4"))] | ||
| impl Default for ClockSource { |
There was a problem hiding this comment.
Nit: you can replace all of this with just #[default] above, because for each MCU you end up with exactly two members of the enum, where the XTAL member should always be the non-default one.
|
Just two nits. I think you can merge without addressing these either, as they are nits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer esp's (c2/h2/c6) don't use the apb clock as a default clock for the timer. They use different variants of the pll clock. Furthermore the general assumption that the xtal clock is always 40Mhz is not correct. This PR includes fixes for the TimeDriver in this respect.
closes #426