Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support esp-idf source tree not being Git repository #241

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

haileys
Copy link

@haileys haileys commented Sep 18, 2023

This is the esp-idf-sys counterpart to esp-rs/embuild#80 - there's more discussion over there


[patch.crates-io.embuild]
git = "https://github.com/haileys/embuild"
branch = "esp-idf-no-git-repo"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just for integration purposes for now, I'll rebase this change away before merge

@ivmarkov
Copy link
Collaborator

@haileys - you need to cargo fmt

@ivmarkov
Copy link
Collaborator

@haileys - ditto here. If this is to be included in the new release, you need to address the CI errors.

@haileys
Copy link
Author

haileys commented Sep 20, 2023

I've pushed up a fmt, but I wasn't able to run clippy locally to see if it wanted any changes

@ivmarkov
Copy link
Collaborator

ivmarkov commented Sep 21, 2023

Here's one way to run it locally (you need to replace the target variable with whatever ESP MCU/target you want to build for, e.g. riscv32imc-esp-espidf).

Regardless, clippy checks pass.

@dlakatos847
Copy link

dlakatos847 commented Jan 30, 2024

What is the current status of this PR's merge? The issue it fixes is really annoying since I cannot use esp-idf from package manager due to the lack of Git repository. Thanks.

@ivmarkov
Copy link
Collaborator

What is the current status of this PR's merge? The issue it fixes is really annoying since I cannot use esp-idf from package manager due to the lack of Git repository. Thanks.

The status is that the patch is abandon-ware ATM, as you can see in the comments.
If you would like to bring it to completion, that would be greatly appreciated!

Only thing is, I gave it a try a couple of months ago, and then somehow I reached the conclusion that there was something in the ESP IDF itself, which was prohibiting it from being used as non-GIT repository. But maybe I was wrong - can't recollect my memories ATM.

I cannot use esp-idf from package manager due to the lack of Git repository. Thanks.

What package manager?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants