-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support esp-idf source tree not being Git repository #241
base: master
Are you sure you want to change the base?
Conversation
This commit brings esp-idf-sys up to date with changes in embuild
|
||
[patch.crates-io.embuild] | ||
git = "https://github.com/haileys/embuild" | ||
branch = "esp-idf-no-git-repo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just for integration purposes for now, I'll rebase this change away before merge
@haileys - you need to |
@haileys - ditto here. If this is to be included in the new release, you need to address the CI errors. |
I've pushed up a fmt, but I wasn't able to run clippy locally to see if it wanted any changes |
Here's one way to run it locally (you need to replace the target variable with whatever ESP MCU/target you want to build for, e.g. Regardless, clippy checks pass. |
What is the current status of this PR's merge? The issue it fixes is really annoying since I cannot use |
The status is that the patch is abandon-ware ATM, as you can see in the comments. Only thing is, I gave it a try a couple of months ago, and then somehow I reached the conclusion that there was something in the ESP IDF itself, which was prohibiting it from being used as non-GIT repository. But maybe I was wrong - can't recollect my memories ATM.
What package manager? |
This is the esp-idf-sys counterpart to esp-rs/embuild#80 - there's more discussion over there