-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update env.rs #420
Update env.rs #420
Conversation
The book says "There is no need to execute the file for Windows users. It is only created to show the modified environment variables.". This appears to be out of date.
Related: #233 Did not appear to get fixed correctly, this is a great way to offer a fix. |
Mind giving some reproduction steps to the issue and which version of |
Certainly! This happened on two windows machine, one a Surface Pro running either Windows 10 or 11, I will have to check later, and a desktop PC that is running Windows 10 Pro. The commands run were:
Version is:
The issue was difficult to reproduce. Keys to reproducing the issue included restarting my PC. Delete the environment changes manually from the registry and restarted my PC. The environment variables still showed up in new shells until I rebotted, likely due to registry caching of some kind, even when I made certain to open new shells both CMD and PowerShell, using WindowsKey+R 'cmd' or WindowsKey+x and i for PowerShell. Both returned the environment variables when echo'd, despite the fact that they were deleted from the registry in RegEdit.
Running I am certain there is an underlying registry caching issue that is causing these environment variables to not be immediately updated, and this probably is likely not limited to me as it's happened on two systems, but it may be caused by SOMETHING that doesn't exist on a completely fresh Windows installation, if that's where you test the issue, but I don't have access to one at the moment. |
Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com>
The book says "There is no need to execute the file for Windows users. It is only created to show the modified environment variables.". This appears to be out of date.
On Windows 10, using powershell in VS Code, nothing builds correctly without first running the environment file as a command.
Fails unless I first do
C:\Users\ryankopf\export-esp.ps1
.