-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sitelen-pona package #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple text replacement package. As it uses a lot of common single-character triggers without prefix or suffix, it won't be for everybody, but I can see it might fit within an app-specific config.
A lot of characters not readable on GitHub, but I fed package.yml to https://www.kreativekorp.com/software/fonts/sitelenselikiwen/ to see how they appear.
No cmd
, shell
, script
or apparently risky code.
The README.md could be more helpful.
Needs some tags and could safely be merged.
title: "o sitelen pona!" | ||
description: A package for writing UCSUR sitelen pona with Espanso! | ||
version: 0.1.0 | ||
author: niko |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs some tags:
. See espanso hub for examples.
Thank you for the review! I'll make some changes |
Thank you. Just awaiting someone else to review the package and I think i can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the README is a problem given that anyone who would want to use this package will already be familiar with Toki Pona.
The changes look good to me!
That took me down a rabbit hole - via a YouTube video, and onto the ma pona pi toki pona Discord server, with several mentions of Espanso! |
Yes, it was a minor point. |
Regarding the readme, I think it would be helpful to list how many and what words are supported by the package, as well as how to use it (as it doesn't use any prefix or suffix, but is intended to be used with Espanso's toggle key feature). |
The tags I was thinking of included "symbols", "languages", "letters", "writing", "characters", "communication" etc.. Having taken a trip down the rabbit hole! the README.md could interest people browsing the packages and encourage them to take the same journey. I can see there is an expanding toki pona community. You don't need to go as far as the one for github-emojis-latest! |
Looks goods! Thank you guys for reviewing and the rapid response of the dev. |
I think adding the tags I suggested would be helpful to hub users. We could do that, but yes. |
I added the tags :) I think I'll write a README.tok.md and I'll be done (or can there only be one readme?) |
It's a valid question, in the instant I was writing this comment smeech merged it 💯 |
I've merged the package. |
The Hub website uses README.md, so I think we should stick to one file. |
It's in: https://hub.espanso.org/sitelen-pona |
Yeah, on the webpage it will load only one readme, but I'm wondering if you donwload the package with |
Added package for typing sitelen pona (toki pona's main writing system) via UCSUR.
If you're wondering, the language at the end of the readme is toki pona, and what I wrote translates to about: