Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add airport-codes package #93

Merged
merged 3 commits into from
Jun 1, 2024
Merged

feat: Add airport-codes package #93

merged 3 commits into from
Jun 1, 2024

Conversation

metal-gabe
Copy link
Contributor

This is a collection of airport code abbreviations that expand into the city names where they reside.

This is a port of the same expansion set found in TextExpander.

@cl3mcg
Copy link
Contributor

cl3mcg commented Apr 22, 2024

Hello @gflujan,
I tried to submit an espanso package that is also related to airport codes.
Do you want to work on a common package ? I don't really know if it is possible, but if you want, let me know.
#92

Copy link
Collaborator

@smeech smeech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simple package listing airport cities. Very little in common with #92.
No cmd:, script, shell or malicious code.
Safe to merge.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not. 🙂 I can remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smeech The file has been removed. Please let me know if you need anything else. Thanks!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I think we're good to go. Just awaiting someone else to review, in case I've overlooked something, and then it'll be merged,

@metal-gabe
Copy link
Contributor Author

Hello @gflujan, I tried to submit an espanso package that is also related to airport codes. Do you want to work on a common package ? I don't really know if it is possible, but if you want, let me know. #92

Hi @cl3mcg, thanks for the offer! But as @smeech noted, I think our two packages are solving for different use cases.

But, I'd be happy to add a link to your package in my README if you're willing to do the same. 🙂

@cl3mcg
Copy link
Contributor

cl3mcg commented May 7, 2024

Hello @gflujan, I tried to submit an espanso package that is also related to airport codes. Do you want to work on a common package ? I don't really know if it is possible, but if you want, let me know. #92

Hi @cl3mcg, thanks for the offer! But as @smeech noted, I think our two packages are solving for different use cases.

But, I'd be happy to add a link to your package in my README if you're willing to do the same. 🙂

Hello @gflujan and thank you for your reply.
I have updated the README.md of my pull request to include a reference and link to your package. 😄
Have a nice day.

…k to the README for the related package from @cl3mcg;
@metal-gabe
Copy link
Contributor Author

Hello @gflujan, I tried to submit an espanso package that is also related to airport codes. Do you want to work on a common package ? I don't really know if it is possible, but if you want, let me know. #92

Hi @cl3mcg, thanks for the offer! But as @smeech noted, I think our two packages are solving for different use cases.
But, I'd be happy to add a link to your package in my README if you're willing to do the same. 🙂

Hello @gflujan and thank you for your reply. I have updated the README.md of my pull request to include a reference and link to your package. 😄 Have a nice day.

Awesome, thanks @cl3mcg! I've updated my README as well to have a link to your package. 🙂

@smeech smeech merged commit ea6337c into espanso:main Jun 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants