Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sf-symbols package #96

Merged
merged 2 commits into from
Jun 1, 2024
Merged

Add sf-symbols package #96

merged 2 commits into from
Jun 1, 2024

Conversation

jonamil
Copy link
Contributor

@jonamil jonamil commented Feb 15, 2024

A package to insert Apple’s SF Symbols, which are part of the SF Pro System Font used within Apple’s platforms.

Copy link
Collaborator

@smeech smeech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A large package of simple expansions.
No cmd:, : shell, : script or malicious code, as far as I can see.
The version in the package path and _manifest.yml needs amending to the hub standard of 0.1.0 by the author or us, as specified in the docs.
Otherwise, fine to merge.

@smeech smeech added the invalid This doesn't seem right label May 6, 2024
@jonamil
Copy link
Contributor Author

jonamil commented May 8, 2024

Thanks for reviewing and for making me aware of this, changed the version accordingly.

@smeech
Copy link
Collaborator

smeech commented May 8, 2024

Thanks for reviewing and for making me aware of this, changed the version accordingly.

Thank you. Once someone else has cast an eye over it we should be good to merge.

@smeech smeech removed the invalid This doesn't seem right label May 8, 2024
@smeech smeech merged commit 1c90086 into espanso:main Jun 1, 2024
1 check passed
@smeech
Copy link
Collaborator

smeech commented Jun 1, 2024

Straightforward, so I've completed the merge,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants