Lighting #46
Merged
Lighting #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks! |
|
This caused a regression in Smashing Drive. |
PatrickvL
reviewed
Jun 11, 2017
| /* lightLocalRange will be 1e+30 here */ | ||
|
|
||
| qstring_append_fmt(h, | ||
| "uniform vec3 lightInfiniteHalfVector%d;\n" |
There was a problem hiding this comment.
Are these two infinite vectors initialized anywhere?
There was a problem hiding this comment.
They are uniforms?
PatrickvL
reviewed
Jun 11, 2017
| @@ -4496,6 +4674,11 @@ static void pgraph_method(NV2AState *d, | |||
| pg->constants[59].dirty = true; | |||
| break; | |||
|
|
|||
| case NV097_SET_EYE_POSITION ... | |||
| NV097_SET_EYE_POSITION + 12: | |||
There was a problem hiding this comment.
+12 implies DWORD offsets 0, 4, 8 and 12 are handled here. But, is eye a vec4 or a vec3? In case of vec3, the fourth write could corrupt another register...
There was a problem hiding this comment.
It is also declared as a four component vector. I don't remember why right now, but I'd assume this might go through some matrix or is normalized somehow (or w is simply ignored).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm aware that this is quite a bit of code and it could possibly break tons of stuff [spotlights assert + lighting could turn a lot of otherwise working things black].
I'm tired of rebasing this all the time - I was going to add spotlights before merging this and was worried it would break a ton of games.
However, @JohnGodgames tested 100+ games with this and the majority still seems to work and look way better.
Some formulas and used variables might not be perfect now, but it's better than nothing? Mhkay?