style: add dark mode 💄 #515
Open
+442
−194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restyled the overall design, loosened up on some drop-shadows, corrected some spacings on the header/ footer and created new design for the device card The changes were mainly applied to the main dashboard. Any subsequent pages have not been affected
Not sure if this is the most efficient implementation of a dark mode toggle. Another Issue I unfortunately don't know how to fix is, saving this choice in local storage, would love to get some guidance on how to achieve that
Not sure if this is the most efficient implementation of a dark mode toggle. Another Issue I unfortunately don't know how to fix is, saving this choice in local storage, would love to get some guidance on how to achieve that
…into style-dark-mode
|
Nice, but please without that toggle button. Mode has to be switched via browser settings (discord thread) |
Removed the toggle. Thanks for pointing it out 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Dark Mode 💄
Note: this PR is dependent on #514
The theme automatically updates in case the system preferences change before or during using the page. Furthermore, there is a toggle if, for some reason, the theme doesn't match the user's preferences.
Here are some screenshots of how this looks like:
Toolbar in Light Mode:
Toolbar in Dark Mode:
Tooltip on hover:
Behaviour:
Bildschirmaufnahme.2023-07-26.um.19.33.27.mov
Light Mode:
Dark Mode: