Fix JSON parse error when backend returns 304 #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some URLs (namely /ping and /serial-ports) tornado will automatically set an ETag Header with the hashed payload.
When there's a cache hit, the backend only returns 304 Not Modified.
HTTP Request/response:
Importantly, for 304 Not Modified the
content-type
header is not sent (the HTTP RFC also specifies 304 to act just like that https://stackoverflow.com/a/31107285)I know it's an ugly fix, but I couldn't find a way to disable the behavior in the backend (tornado has horrible docs). So instead fix it in the frontend (where ideally it should be fixed anyway, because the HTTP RFC recommends this behavior)