Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apollo Automation Devices #638

Merged
merged 18 commits into from
Jul 4, 2024
Merged

Conversation

Bunton33
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Jan 25, 2024

Deploy Preview for esphome-devices ready!

Name Link
🔨 Latest commit 6e28ee9
🔍 Latest deploy log https://app.netlify.com/sites/esphome-devices/deploys/6685f2fba9f9590008572f77
😎 Deploy Preview https://deploy-preview-638--esphome-devices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🟢 up 3 from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 81 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@manafount manafount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far! I left a few comments about some minor styling stuff, but I didn't find anything that needed a major correction. You may want to call out the optional sensors in the list of components for clarity, though. Ex:

  - (Optional) MiCS-4514 ...

Reading through some other device pages, it looks like Github-flavor markdown is generally supported. If you're looking for ideas for styling, there's a good doc available here

@manafount
Copy link

Just looked at the new revisions, and this looks great to me! I can't approve it, but you have my :shipit: in spirit!

src/docs/devices/Apollo-Automation-AIR-1/index.md Outdated Show resolved Hide resolved
src/docs/devices/Apollo-Automation-MSR-1/index.md Outdated Show resolved Hide resolved
src/docs/devices/Apollo-Automation-MSR-2/index.md Outdated Show resolved Hide resolved
src/docs/devices/Apollo-Automation-MTR-1/index.md Outdated Show resolved Hide resolved
@esphome esphome bot marked this pull request as draft July 4, 2024 00:54
@esphome
Copy link

esphome bot commented Jul 4, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@kbx81 kbx81 marked this pull request as ready for review July 4, 2024 00:55
@esphome esphome bot requested a review from kbx81 July 4, 2024 00:55
@kbx81 kbx81 merged commit 319eba7 into esphome:main Jul 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants