-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Apollo Automation Devices #638
Conversation
✅ Deploy Preview for esphome-devices ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far! I left a few comments about some minor styling stuff, but I didn't find anything that needed a major correction. You may want to call out the optional sensors in the list of components for clarity, though. Ex:
- (Optional) MiCS-4514 ...
Reading through some other device pages, it looks like Github-flavor markdown is generally supported. If you're looking for ideas for styling, there's a good doc available here
…sphome-devices into Add-Apollo-Automation
Just looked at the new revisions, and this looks great to me! I can't approve it, but you have my in spirit! |
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
No description provided.