-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
host platform: improvements and bugfixes #6137
Conversation
Allow setting mac address for host.
Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration ( |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6137 +/- ##
=======================================
Coverage 53.70% 53.71%
=======================================
Files 50 50
Lines 9403 9404 +1
Branches 1653 1653
=======================================
+ Hits 5050 5051 +1
Misses 4055 4055
Partials 298 298 ☔ View full report in Codecov by Sentry. |
fix text_sensor virtual methods; replace sprintf with snprintf in helpers.
fix text_sensor filter declarations.
Clyde could you show me your YAML file where you use this and the VLC client. So i can us it myself as well? |
Sure. All the necessary stuff is merged into the lvgl branch. Sample host.yaml:
|
Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration ( |
What does this implement/fix?
Tweaks to make the
host:
platform more usable.The mac address was not being initialised on the host: platform, so would change randomly. This allows it to be configured, not perhaps as good as getting an actual one, but since there are likely to be multiple hardware interfaces, that's not really practical.
The sntp component just gets the current system time on host:
The text_sensor component had some incorrect C++ declaring virtual methods;
Replace
sprintf
withsnprintf
in helpers (NB there are still plenty of places in the codebase where this needs doing.)Add timestamps to logger output (this is done by the logging program for non-host platforms.)
Types of changes
Related issue or feature (if applicable): fixes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: