Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support inkplate 5 and 5 V2 #7448

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Support inkplate 5 and 5 V2 #7448

merged 4 commits into from
Sep 25, 2024

Conversation

DavidSichau
Copy link
Contributor

@DavidSichau DavidSichau commented Sep 15, 2024

Provide support for inkplate 5 and 5 V2

What does this implement/fix?

Waveform was used the one of the Inkplate repo.

Support inkplate 5 and 5V2 displays,

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes esphome/feature-requests#2884

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#4276

Test Environment

  • ESP32 Inkplate 5

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

Provide support for inkplate 5 and 5 V2
@probot-esphome
Copy link

Hey there @jesserockz, mind taking a look at this pull request as it has been labeled with an integration (inkplate6) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.97%. Comparing base (4d8b5ed) to head (6c101ba).
Report is 1361 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #7448      +/-   ##
==========================================
+ Coverage   53.70%   53.97%   +0.26%     
==========================================
  Files          50       50              
  Lines        9408     9687     +279     
  Branches     1654     1711      +57     
==========================================
+ Hits         5053     5229     +176     
- Misses       4056     4127      +71     
- Partials      299      331      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add the models to the config options

MODELS = {
"inkplate_6": InkplateModel.INKPLATE_6,
"inkplate_10": InkplateModel.INKPLATE_10,
"inkplate_6_plus": InkplateModel.INKPLATE_6_PLUS,
"inkplate_6_v2": InkplateModel.INKPLATE_6_V2,
}

esphome/components/inkplate6/inkplate.h Outdated Show resolved Hide resolved
@esphome esphome bot marked this pull request as draft September 15, 2024 23:08
@esphome
Copy link

esphome bot commented Sep 15, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

DavidSichau and others added 2 commits September 16, 2024 09:42
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
@DavidSichau
Copy link
Contributor Author

@jesserockz I added the requested changes. Thanks for the review.

@DavidSichau DavidSichau marked this pull request as ready for review September 16, 2024 07:45
@esphome esphome bot requested a review from jesserockz September 16, 2024 07:45
@DavidSichau
Copy link
Contributor Author

Doc was added: esphome/esphome-docs#4276

@jesserockz jesserockz merged commit 294fe8d into esphome:dev Sep 25, 2024
25 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add inkplate 5 display
3 participants