-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support inkplate 5 and 5 V2 #7448
Conversation
Provide support for inkplate 5 and 5 V2
Hey there @jesserockz, mind taking a look at this pull request as it has been labeled with an integration ( |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #7448 +/- ##
==========================================
+ Coverage 53.70% 53.97% +0.26%
==========================================
Files 50 50
Lines 9408 9687 +279
Branches 1654 1711 +57
==========================================
+ Hits 5053 5229 +176
- Misses 4056 4127 +71
- Partials 299 331 +32 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to add the models to the config options
esphome/esphome/components/inkplate6/display.py
Lines 51 to 56 in f652cd3
MODELS = { | |
"inkplate_6": InkplateModel.INKPLATE_6, | |
"inkplate_10": InkplateModel.INKPLATE_10, | |
"inkplate_6_plus": InkplateModel.INKPLATE_6_PLUS, | |
"inkplate_6_v2": InkplateModel.INKPLATE_6_V2, | |
} |
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
@jesserockz I added the requested changes. Thanks for the review. |
Doc was added: esphome/esphome-docs#4276 |
Provide support for inkplate 5 and 5 V2
What does this implement/fix?
Waveform was used the one of the Inkplate repo.
Support inkplate 5 and 5V2 displays,
Types of changes
Related issue or feature (if applicable): fixes esphome/feature-requests#2884
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#4276
Test Environment
Checklist:
tests/
folder).