axTSL client_hello cipher verification failure (GIT8266O-269) #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -150,7 +150,7 @@ static int ICACHE_FLASH_ATTR process_client_hello(SSL *ssl) | |||
|
|
|||
| offset += id_len; | |||
| cs_len = (buf[offset]<<8) + buf[offset+1]; | |||
| offset += 3; /* add 1 due to all cipher suites being 8 bit */ | |||
There was a problem hiding this comment.
And this is wrong, as later in the code they check 16 bit ciphers. And since they missed high byte of the chiper, they check low byte of chiper + high byte of next cipher, which is wrong.
|
Max Stepanov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
github-actions
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed axTLS bug of wrong cipher extraction from client_hello during SSL handshake.
See issue #66 for detailed explanation.