Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.05 board library breaks a few things #4905

Closed
JimDrewGH opened this issue Mar 7, 2021 · 11 comments
Closed

v1.05 board library breaks a few things #4905

JimDrewGH opened this issue Mar 7, 2021 · 11 comments
Labels
Area: ESP-IDF related ESP-IDF related issues Status: Stale Issue is stale stage (outdated/stuck)

Comments

@JimDrewGH
Copy link

JimDrewGH commented Mar 7, 2021

Board: Any
Core Installation version: 1.05
IDE name: Arduino IDE

Since upgrading to v1.05 board library, none of the nifty video projects from Rossumur (https://github.com/rossumur), or any derivatives, will now work. The ESP_8_Bit and ESPFlix are projects that output color composite video. No video is now output at all with ESP_8_bit (but compilation is fine) and ESPFlix now generates this error when compiling:

//----------------------------------------------------------
C:\Users\Main\Documents\Arduino\ESPFLIX\espflix.ino: In function 'void wifi_join(const char*, const char*)':
espflix:203:54: error: cannot convert 'esp_interface_t' to 'wifi_interface_t' for argument '1' to 'esp_err_t esp_wifi_set_config(wifi_interface_t, wifi_config_t*)'
esp_wifi_set_config(ESP_IF_WIFI_STA, &wifi_config);
^
C:\Users\Main\Documents\Arduino\ESPFLIX\espflix.ino: In function 'std::__cxx11::string wifi_ssid()':
espflix:212:53: error: cannot convert 'esp_interface_t' to 'wifi_interface_t' for argument '1' to 'esp_err_t esp_wifi_get_config(wifi_interface_t, wifi_config_t*)'
esp_wifi_get_config(ESP_IF_WIFI_STA,&wifi_config);
^
exit status 1
cannot convert 'esp_interface_t' to 'wifi_interface_t' for argument '1' to 'esp_err_t esp_wifi_set_config(wifi_interface_t, wifi_config_t*)'
//----------------------------------------------------------

Going back to v1.02, v1.03, or v1.04 of the board library makes everything work fine.

@JimDrewGH JimDrewGH changed the title v1.05 board library breaks a number of things v1.05 board library breaks a few things Mar 7, 2021
@lbernstone
Copy link
Contributor

Those are upstream changes. The maintainer of those libraries will need to update their code, just as the maintainer of this repository had to make changes to work with the framework.

@JimDrewGH
Copy link
Author

The ESP_8_Bit app is hung in a loop much like other devices that have been recently described here in other reports. I can't imagine this is something that has to be fixed by every programmer moving forwards. One would expect a certain level of backwards compatibility with previous board versions. Clearly things like the compile error are due to changes in the framework. Where is that documented?

@igrr
Copy link
Member

igrr commented Mar 8, 2021

@JimDrewGH Sorry for this issue, it was introduced in ESP-IDF for C++ code when changing the definition of wifi_interface_t. We haven't noticed it until recently because most of our test and example code in IDF is in C, where conversions between different enum types are allowed. We will find a solution for this issue and try to get it implemented in the next bugfix release of Arduino-esp32.

@igrr igrr added the Area: ESP-IDF related ESP-IDF related issues label Mar 8, 2021
@espxiehang
Copy link

Hi @JimDrewGH , In order to avoid this issue, I will reverse the change of wifi_interface_t.
in your project, changing ESP_IF_WIFI_STA to WIFI_IF_STA can solve this issue.
And after wifi_interface_t changes revert, it can also work normally.

@JimDrewGH
Copy link
Author

JimDrewGH commented Mar 9, 2021

Thanks for the note guys! I look forward to a future release. I am hoping that also fixes the composite video problem for the projects mentioned in my original post. This issue seems to be involving the setup of the I2S and APLL.

espressif-bot pushed a commit to espressif/esp-idf that referenced this issue Mar 18, 2021
@me-no-dev
Copy link
Member

Change is now in the idf-release/v3.3 branch of this repository. Could you please test and confirm that everything is OK?

@JimDrewGH
Copy link
Author

I would be happy to test this, but I am not sure what I should be doing to get the latest release (3.3). Keep in mind that I am using whatever the Arduino IDE installs but I can grab and replace files. I just need to know where they are and where they go. :)

@lbernstone
Copy link
Contributor

lbernstone commented Mar 20, 2021

Uninstall from board manager, then install the development repository. You will need to git checkout idf-release/v3.3 to get this change.

@JimDrewGH
Copy link
Author

OK, thanks!

@stale
Copy link

stale bot commented Jun 18, 2021

[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Stale Issue is stale stage (outdated/stuck) label Jun 18, 2021
@stale
Copy link

stale bot commented Jul 11, 2021

[STALE_DEL] This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: ESP-IDF related ESP-IDF related issues Status: Stale Issue is stale stage (outdated/stuck)
Projects
None yet
Development

No branches or pull requests

5 participants