Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TTGO LoRa32 with OLED Version 1.x Board #1663

Merged
merged 3 commits into from
Jul 24, 2018
Merged

Add TTGO LoRa32 with OLED Version 1.x Board #1663

merged 3 commits into from
Jul 24, 2018

Conversation

CaptIgmu
Copy link
Contributor

No description provided.

static const uint8_t RX = 3;

static const uint8_t SDA = 21;
static const uint8_t SCL = 22;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is, SDA and SCL accurate? How is the OLED connected? How is the LORA sx1276 connected? If the OLED is not using 21,22 I would recommend you add additional defines

// OLed
static const uint8_t OLED_SCL = 15;
static const uint8_t OLED_SDA = 4;
static const uint8_t OLED_RST = 16;

// LoRA
static const uint8_t LORA_SCK = 5;
static const uint8_t LORA_MOSI = 27;
static const uint8_t LORA_MISO = 19;
static const uint8_t LORA_CS = 18;
static const uint8_t LORA_RST = 14;
static const uint8_t LORA_IRQ = 26;

It think it would be useful.
Chuck.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And we have LED and button on board:

// LED (attn: is active low!)
static const uint8_t LED_BUILTIN = 2;

// button ("PRG")
static const uint8_t BUTTON = 0;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stickbreaker The Version 1 boards use pins 4,15,16 for OLED so makes more sense to get these definitions into pins_arduino.h along with the LoRa radio defs. I had these in my example programs at CaptIgmu/Arduino/tree/master/esp32/TTGO_LoRa32_OLED. Thank you Chuck, I will add some commits!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cyberman54 These are defined in pins_arduino.h

static const uint8_t LED_BUILTIN = 2;
#define BUILTIN_LED  LED_BUILTIN // backward compatibility

static const uint8_t KEY_BUILTIN = 0;

I don't need the PRG button in my applications but you could re-assign the constant in your program! Thanks.

@stickbreaker
Copy link
Contributor

@CaptIgmu I like those changes, now for the official repo managers to agree.

Chuck.

@me-no-dev
Copy link
Member

We need to do something about this boards :D the file is becoming unmaintainable

@me-no-dev me-no-dev merged commit da798c7 into espressif:master Jul 24, 2018
@CaptIgmu CaptIgmu deleted the TTGO-LoRa32-V1 branch August 1, 2018 04:59
@CaptIgmu CaptIgmu restored the TTGO-LoRa32-V1 branch August 1, 2018 05:06
Curclamas pushed a commit to Curclamas/arduino-esp32 that referenced this pull request Aug 21, 2018
* Add ttgo-lora32-v1 folder to variants folder

* Add ttgo-lora32-v1 info to boards.txt

* Add defs to pins_arduino.h for I2C OLED and SPI LoRa radio pinouts as per @stickbreaker
@CaptIgmu CaptIgmu deleted the TTGO-LoRa32-V1 branch March 18, 2019 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants