Fixed Arduino SPI/Ethernet compile issue as described in issue #1623 #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splitted suggested fix issue espressif#1623 in a header and source part. Dit not completely dive into the code. Giving data twice as parameter feels wrong, but it compiles, and i can succesfully use the W5500 with SPI with this fix. Doesn't compile without.
Splitted suggested fix issue espressif#1623 in a header and source part. Dit not completely dive into the code. Giving data twice as parameter feels wrong, but it compiles, and i can succesfully use the W5500 with SPI with this fix. Doesn't compile without.
iafilius
changed the title
|
thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
implemented missing SPI.transfer, required to compile Arduino SPI based Ethernet (W5500)
Splitted the suggested change in Issue #1623, in a header and source part. It compiles, works, but i'm not completely confident with exact location, and if this would be the best solution.
Please review, and accept the proposal.
Not completely feeling confident with providing the data parameter twice to the transferBytes function, please, just copied it form the suggested solution in #1623 .
Regards,
Arjan