io_pin_remap fixes for the Arduino Nano ESP32 #8489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since tone() can have either 2 or 3 parameters, pass any argument after the first to the actual function implementation.
Building with BOARD_HAS_PIN_REMAP but without setting ARDUINO_CORE_BUILD on core files is absolutely forbidden, as this would lead to multiple pin remappings being silently applied on the same numbers. Also advise the user when, on a board that has a custom pin mapping, - the core is being built without pin mapping support, or - the user explictly asked to use GPIO pin numbers.
me-no-dev
pushed a commit
that referenced
this pull request
Sep 4, 2023
* io_pin_remap: fix tone() function mapping declaration Since tone() can have either 2 or 3 parameters, pass any argument after the first to the actual function implementation. * io_pin_remap: add sanity checks to the core build Building with BOARD_HAS_PIN_REMAP but without setting ARDUINO_CORE_BUILD on core files is absolutely forbidden, as this would lead to multiple pin remappings being silently applied on the same numbers. Also advise the user when, on a board that has a custom pin mapping, - the core is being built without pin mapping support, or - the user explictly asked to use GPIO pin numbers.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@me-no-dev
Description of Change
dec6db6 fixes a minor issue: the pin-remapping macros force
tone()to have 3 parameters, while the Arduino API dictates the third is optional.9b402f0 adds an error and warnings to detect issues with bad or non-standard
#definecombinations for the variants with defined custom pin-mapping. No noticeable effects on a normal core build.Tests scenarios
Applicable to Arduino Nano ESP32 board only (other variants not using custom pin numbering are unaffected).
Tested that now:
-DARDUINO_CORE_BUILDlines inplatform.txtstops the build with an error-DBOARD_HAS_PIN_REMAPmacro inboards.txttriggers a warning-DBOARD_USES_HW_GPIO_PIN_NUMBERSmacro at compile time triggers a warningRelated links
The changes have been discussed in the PlatformIO repo here and is related to PR #8488 (fixing the original issue).